linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: linuxppc-embedded@lists.linuxppc.org
Cc: Paul Mackerras <paulus@samba.org>
Subject: Organisation of 4xx initialization code
Date: Fri, 16 Nov 2001 16:46:26 +1100	[thread overview]
Message-ID: <20011116164625.K673@zax> (raw)


At the moment the initialization for each of the 4xx boards goes
through the platform_init() in arch/ppc/kernel/ppc4xx_setup.c, which
in turns calls a board_init() function for the specific board.

It seems to me that it would make more sense to put platform_init() in
the board specific files, and these functions could then call back,
where appropriate, to generic 4xx setup functions.  This would mean:
	- It would be easier to support wierd and wacky boards which
have non-standard address setups.
	- Some ugly #ifdefs in ppc4xx_setup.c could be done away with.
	- We should be able to remove some inconvenient header
dependencies - at present lots of things are recompiled when board
local defines are changed because walnut.h/ep405.h/etc are included
indirectly in serial.h and some other unexpected places.

Thoughts?

--
David Gibson			| For every complex problem there is a
david@gibson.dropbear.id.au	| solution which is simple, neat and
				| wrong.  -- H.L. Mencken
http://www.ozlabs.org/people/dgibson


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

             reply	other threads:[~2001-11-16  5:46 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-16  5:46 David Gibson [this message]
2001-11-16 11:57 ` Organisation of 4xx initialization code Matt Porter
2001-11-16 15:51   ` Tom Rini
2001-11-16 16:42     ` Matt Porter
2001-11-16 17:13       ` Tom Rini
2001-11-16 23:24         ` Dan Malek
2001-11-17  0:43           ` David Gibson
2001-11-17  1:01             ` Dan Malek
2001-11-17  2:18             ` Tom Rini
2001-11-17 11:16               ` Paul Mackerras
2001-11-17 12:43                 ` Ralph Blach
2001-11-17 14:46                   ` Mark Pilon
2001-11-17  0:50       ` David Gibson
2001-11-17  2:16         ` Tom Rini
2001-11-17  0:35     ` David Gibson
2001-11-17  2:18       ` Tom Rini
2001-11-16 16:07   ` Mark Pilon
2001-11-16 17:29     ` Tom Rini
2001-11-16 14:59 ` Tom Rini
2001-11-17  0:40   ` David Gibson
2001-11-17  2:15     ` Tom Rini
2001-11-16 16:46 ` Dan Malek
2001-11-17  0:47   ` David Gibson
2001-11-17  1:11     ` Dan Malek
2001-11-16 17:15 ` Armin Kuster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011116164625.K673@zax \
    --to=david@gibson.dropbear.id.au \
    --cc=linuxppc-embedded@lists.linuxppc.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).