Re: Organisation of 4xx initialization code

[David Gibson <david@gibson.dropbear.id.au>]

On Fri, Nov 16, 2001 at 06:24:13PM -0500, Dan Malek wrote:
> >I think right now, 4xx is done in a different way intentionally.
>
> I'm not so sure :-).  I think it started off badly, is getting better,
> and from these discussions we have clearly learned how to better
> structure the software.  From the variety of 4xx projects I have worked
> on, I'm still making the kinds of changes to better utilize and structure
> existing software.  I feel like I'm doing the same thing I did years ago
> with the 8xx, only back then no one cared what I was doing (because it
> was some embedded stuff that didn't seem to interest anyone :-).
>
> >..... There's common
> >ground, with hooks for board-specific stuff.
>
> I could argue the 7xx stuff is this way as well.  Every board should
> probably
> have a platform_init() that calls the processor architecture unique
> functions.
> I am a little confused that there doesn't seem to be as many platform_init()
> calls as there are boards we support (just 'grep for it' in the kernel
> directory).  So, there is probably work to do for all boards we support.

That's exactly my point:  platform_init() for *all* 4xx boards is in
ppc4xx_setup.c, which then calls a board_init() function which comes
from the particular board.

> It seems we should call some early architecture generic init functions (if
> necessary), then platform init, then more general architecture functions
> if necessary.

No need - the board's platform_init() can call the processor general
functions if necessary.

--
David Gibson			| For every complex problem there is a
david@gibson.dropbear.id.au	| solution which is simple, neat and
				| wrong.  -- H.L. Mencken
http://www.ozlabs.org/people/dgibson

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/