'make rpm' Failing due to i386 bug

'make rpm' Failing due to i386 bug

[Joseph Manojlovich]

Hey all. I was using the latest stable branch from source.mvista.com,
and noticed that 'make rpm' wasn't working. Looking closer, I noticed
that a supporting script, scripts/mkspec, is quite 386 specific. It
makes an rpm spec file that assumes the kernel image is compressed,
which with ppc it isn't (for me at least).

Here's a quick patch which fixes this for the ppc platform, but would
not work on platforms that use compressed kernel images, like x86. I'm
not looking forward to fixing the make system for the kernel, so if
anyone wants to permanently fix this, it would be appreciated.

--- linuxppc-old/scripts/mkspec	Sun Nov 18 03:45:21 2001
+++ linuxppc/scripts/mkspec	Tue Nov 27 22:02:17 2001
@@ -28,12 +28,12 @@
 echo "%setup -q"
 echo ""
 echo "%build"
-echo "make oldconfig dep clean bzImage modules"
+echo "make oldconfig dep clean vmlinux modules"
 echo ""
 echo "%install"
 echo 'mkdir -p $RPM_BUILD_ROOT/boot $RPM_BUILD_ROOT/lib $RPM_BUILD_ROOT/lib/modules'
 echo 'INSTALL_MOD_PATH=$RPM_BUILD_ROOT make modules_install'
-echo 'cp arch/i386/boot/bzImage $RPM_BUILD_ROOT'"/boot/vmlinuz-$VERSION.$PATCHLEVEL.$SUBLEVEL$EXTRAVERSION"
+echo 'cp vmlinux $RPM_BUILD_ROOT'"/boot/vmlinux-$VERSION.$PATCHLEVEL.$SUBLEVEL$EXTRAVERSION"
 echo 'cp System.map $RPM_BUILD_ROOT'"/boot/System.map-$VERSION.$PATCHLEVEL.$SUBLEVEL$EXTRAVERSION"
 echo ""
 echo "%clean"

(end of patch)

--
Joe Manojlovich
manojlov@cse.psu.edu
"And a thermostat on a home furnace... is that supposed to go to
 5000 degrees, do you think?"

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: 'make rpm' Failing due to i386 bug

[Tom Rini]

On Tue, Nov 27, 2001 at 11:32:24PM -0500, Joseph Manojlovich wrote:

> Hey all. I was using the latest stable branch from source.mvista.com,
> and noticed that 'make rpm' wasn't working. Looking closer, I noticed
> that a supporting script, scripts/mkspec, is quite 386 specific. It
> makes an rpm spec file that assumes the kernel image is compressed,
> which with ppc it isn't (for me at least).

You could try %ifarch ppc ... %else .. %endif.  Tho we do have a
'bzImage' target, and yaboot might even do the 'zimages' on pmac as well
as chrp now.  Talk to Alan Cox since this is his script anyhow.

--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: 'make rpm' Failing due to i386 bug

[Ethan Benson]

On Wed, Nov 28, 2001 at 10:49:26AM -0700, Tom Rini wrote:
>
> On Tue, Nov 27, 2001 at 11:32:24PM -0500, Joseph Manojlovich wrote:
>
> > Hey all. I was using the latest stable branch from source.mvista.com,
> > and noticed that 'make rpm' wasn't working. Looking closer, I noticed
> > that a supporting script, scripts/mkspec, is quite 386 specific. It
> > makes an rpm spec file that assumes the kernel image is compressed,
> > which with ppc it isn't (for me at least).
>
> You could try %ifarch ppc ... %else .. %endif.  Tho we do have a
> 'bzImage' target, and yaboot might even do the 'zimages' on pmac as well
> as chrp now.  Talk to Alan Cox since this is his script anyhow.

no we have a zImage target, not bzImage which is a i386 specific hack
to work around that braindamaged architecture.

--
Ethan Benson
http://www.alaska.net/~erbenson/

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: 'make rpm' Failing due to i386 bug

[Tom Rini]

On Wed, Nov 28, 2001 at 04:06:15PM -0900, Ethan Benson wrote:
>
> On Wed, Nov 28, 2001 at 10:49:26AM -0700, Tom Rini wrote:
> >
> > On Tue, Nov 27, 2001 at 11:32:24PM -0500, Joseph Manojlovich wrote:
> >
> > > Hey all. I was using the latest stable branch from source.mvista.com,
> > > and noticed that 'make rpm' wasn't working. Looking closer, I noticed
> > > that a supporting script, scripts/mkspec, is quite 386 specific. It
> > > makes an rpm spec file that assumes the kernel image is compressed,
> > > which with ppc it isn't (for me at least).
> >
> > You could try %ifarch ppc ... %else .. %endif.  Tho we do have a
> > 'bzImage' target, and yaboot might even do the 'zimages' on pmac as well
> > as chrp now.  Talk to Alan Cox since this is his script anyhow.
>
> no we have a zImage target, not bzImage which is a i386 specific hack
> to work around that braindamaged architecture.

No, we as of 2.4.10ish have a 'bzImage' target which calls 'zImage'
since most of the docs are braindead and say "Now type 'bzImage' or
'bzdisk'".

--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: 'make rpm' Failing due to i386 bug

[Ethan Benson]

On Wed, Nov 28, 2001 at 08:19:49PM -0700, Tom Rini wrote:
> > no we have a zImage target, not bzImage which is a i386 specific hack
> > to work around that braindamaged architecture.
>
> No, we as of 2.4.10ish have a 'bzImage' target which calls 'zImage'
> since most of the docs are braindead and say "Now type 'bzImage' or
> 'bzdisk'".

hrm, i would have made it echo something like:

	bzImage is a i386 specific hack, it is not supported by any other
	architecure.  Use make zImage instead.

rather then just silently perpetuate further ignorance.

--
Ethan Benson
http://www.alaska.net/~erbenson/

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: 'make rpm' Failing due to i386 bug

[Tom Rini]

On Wed, Nov 28, 2001 at 10:10:45PM -0900, Ethan Benson wrote:
>
> On Wed, Nov 28, 2001 at 08:19:49PM -0700, Tom Rini wrote:
> > > no we have a zImage target, not bzImage which is a i386 specific hack
> > > to work around that braindamaged architecture.
> >
> > No, we as of 2.4.10ish have a 'bzImage' target which calls 'zImage'
> > since most of the docs are braindead and say "Now type 'bzImage' or
> > 'bzdisk'".
>
> hrm, i would have made it echo something like:
>
> 	bzImage is a i386 specific hack, it is not supported by any other
> 	architecure.  Use make zImage instead.
>
> rather then just silently perpetuate further ignorance.

Well, there's precidence since arm I think does the same thing.  And on
m68k 'bzImage' creates a bzip2'ed vmlinux. :)

--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: 'make rpm' Failing due to i386 bug

[Geert Uytterhoeven]

On Thu, 29 Nov 2001, Tom Rini wrote:
> On Wed, Nov 28, 2001 at 10:10:45PM -0900, Ethan Benson wrote:
> > On Wed, Nov 28, 2001 at 08:19:49PM -0700, Tom Rini wrote:
> > > > no we have a zImage target, not bzImage which is a i386 specific hack
> > > > to work around that braindamaged architecture.
> > >
> > > No, we as of 2.4.10ish have a 'bzImage' target which calls 'zImage'
> > > since most of the docs are braindead and say "Now type 'bzImage' or
> > > 'bzdisk'".
> >
> > hrm, i would have made it echo something like:
> >
> > 	bzImage is a i386 specific hack, it is not supported by any other
> > 	architecure.  Use make zImage instead.
> >
> > rather then just silently perpetuate further ignorance.
>
> Well, there's precidence since arm I think does the same thing.  And on
> m68k 'bzImage' creates a bzip2'ed vmlinux. :)

Which has a very questionable purpose, since AFAIK no m68k booter knows how to
decompress bzip2ed kernel images. All they support are plain and gzipped
kernel images.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/