linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Bryce McKinlay <bryce@waitaki.otago.ac.nz>
Cc: <linuxppc-dev@lists.linuxppc.org>,
	Jeff Koftinoff <jeffk@jdkoftinoff.com>, <havardk@xmms.org>
Subject: Re: Byte order in sound drivers
Date: Sun, 2 Dec 2001 10:56:51 +0100	[thread overview]
Message-ID: <20011202095651.24942@smtp.wanadoo.fr> (raw)
In-Reply-To: <3C099A81.6040506@waitaki.otago.ac.nz>


>
>The most recent release of XMMS (0.9.5) works correctly for me for both
>MP3 and WAV files, but not CD audio for which the input plugin returns
>sound in the native endian-ness.

So far, I had MP3s working but not WAV nor cdread (blank noise in both
cases). I didn't yet try 0.9.5 though.

>But, since that release, the following change was made in XMMS CVS:
>
>Thu Jul  5 12:25:51 CEST 2001  Håvard Kvålen  <havardk@xmms.org>
>
>    * Output/OSS/audio.c (oss_set_audio_params): Do endian/sign
>    conversion if necessary.
>
>
>This breaks it on LinuxPPC 2.4.14-ben0 with both the dmasound and
>usb/audio drivers (but, amusingly, fixes the CD audio). Another
>application, mplayer, also seems to have the same problem - it says
>something like "big endian detected, byte conversion enabled" and
>doesn't work, except for 8-bit sound files.
>
>What I want to know is whether these applications are wrong to do this -
>does the Linux PPC audio drivers expect audio to be little endian?

It depends on the HW you have. Most recent machines don't do HW
byteswap, and so accept only big-endian samples. The way this is
implemented in our driver currently is a bit weird though, the
setformat ioctl won't fail when trying to set an LE format, but
it will set the equivalent BE format. So the application is
expected to read back the format to figure out what had to be
done.

Ben.


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

  parent reply	other threads:[~2001-12-02  9:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-12-01 10:16 Byte order in sound drivers Bryce McKinlay
2001-12-01 10:38 ` Jeff Koftinoff
2001-12-02  3:05   ` Bryce McKinlay
2001-12-02  3:14     ` Bryce McKinlay
2001-12-02  9:56     ` Benjamin Herrenschmidt [this message]
2001-12-02 17:17       ` Benjamin Herrenschmidt
2001-12-09 18:00         ` Giuliano Pochini
2001-12-02 18:42       ` Haavard Kvaalen
2001-12-02 22:39       ` Bryce McKinlay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011202095651.24942@smtp.wanadoo.fr \
    --to=benh@kernel.crashing.org \
    --cc=bryce@waitaki.otago.ac.nz \
    --cc=havardk@xmms.org \
    --cc=jeffk@jdkoftinoff.com \
    --cc=linuxppc-dev@lists.linuxppc.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).