From: hollis@austin.ibm.com
To: Michael Sokolov <msokolov@ivan.Harhan.ORG>
Cc: linuxppc-dev@lists.linuxppc.org, davidm@amberdata.demon.co.uk
Subject: Re: RFC: i8259.c & PCI int ack
Date: Mon, 3 Dec 2001 16:46:16 -0600 [thread overview]
Message-ID: <20011203164616.I421@austin.ibm.com> (raw)
In-Reply-To: <0112032237.AA11733@ivan.Harhan.ORG>
On Mon, Dec 03, 2001 at 02:37:56PM -0800, Michael Sokolov wrote:
> hollis@austin.ibm.com wrote:
>
> > - i8259_init now takes a 'long intack_addr', which on PReP is 0xbffffff0.
> > For platforms that only poll, this argument is irrelevant and can be 0x0
> >
> > [...]
> >
> > If this is the right idea, I intend to change all 8259 users:
> > - ppc_md.get_irq = i8259_irq -> ppc_md.get_irq = i8259_poll
> > - i8259_init() -> i8259_init(0x0)
> > - i8259_irq(smp_processor_id()) -> i8259_poll()
>
> With this patch on platforms that only poll, your code will still do an
> ioremap on i8259_init's argument, even if it's 0. I'm not sure that is good.
Good point; fixed.
-Hollis
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2001-12-03 22:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-03 22:37 RFC: i8259.c & PCI int ack Michael Sokolov
2001-12-03 22:46 ` hollis [this message]
-- strict thread matches above, loose matches on Subject: below --
2001-12-03 22:09 hollis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011203164616.I421@austin.ibm.com \
--to=hollis@austin.ibm.com \
--cc=davidm@amberdata.demon.co.uk \
--cc=linuxppc-dev@lists.linuxppc.org \
--cc=msokolov@ivan.Harhan.ORG \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).