From: Peter Bergner <bergner@brule.borg.umn.edu>
To: Adam C Powell IV <hazelsct@mit.edu>
Cc: linuxppc-dev@lists.linuxppc.org
Subject: Re: Why require CONFIG_BOOTX_TEXT for so much of offb?
Date: Wed, 12 Dec 2001 13:05:22 -0600 [thread overview]
Message-ID: <20011212130522.A238707@brule.borg.umn.edu> (raw)
In-Reply-To: <3C158758.5020608@mit.edu>
: So here are my questions:
:
: * Is there a way around this?
: * Is the test for BootX at the start of offb_init() somehow
: insufficient, such that all of this code must be eliminated if
: non-BootX booting is to work?
: * Or is there in fact a hard dependency of that code on other stuff
: provided by CONFIG_BOOTX_TEXT?
: * Is there some way of separating the two, so a single kernel can
: work with BootX and with all versions of OpenFirmware?
: * What's the point of offb without this section of code?
I believe I'm the person responsible for adding the #ifdef CONFIG_BOOTX_TEXT
to the code. IIRC (it's been a while), the problem with that code is that
when compiling the ppc64 kernel, you get a compile error when building that
file:
offb.c:38:23: asm/bootx.h: No such file or directory
Given that bootx doesn't exist in ppc64 and the code seemed to be used
_only_ for bootx, I wrapped it with the "#ifdef CONFIG_BOOTX_TEXT".
Since it's a problem for you, replacing the uses of "#ifdef CONFIG_BOOTX_TEXT"
(there are 3 uses of it) with "#ifndef CONFIG_PPC64" instead would probably
work for me and fix your problem too.
Peter
--
Peter Bergner
SLIC Optimizing Translator Development / Linux PPC64 Kernel Development
IBM Rochester, MN
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2001-12-12 19:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-11 4:11 Why require CONFIG_BOOTX_TEXT for so much of offb? Adam C Powell IV
2001-12-12 19:05 ` Peter Bergner [this message]
2001-12-13 2:00 ` Tom Rini
2001-12-13 16:58 ` Peter Bergner
2001-12-13 17:04 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011212130522.A238707@brule.borg.umn.edu \
--to=bergner@brule.borg.umn.edu \
--cc=hazelsct@mit.edu \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).