From: Val Henson <val@nmt.edu>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@lists.linuxppc.org
Subject: Re: [PATCH] fix heartbeat
Date: Sat, 9 Feb 2002 17:23:53 -0700 [thread overview]
Message-ID: <20020209172353.A32151@boardwalk> (raw)
In-Reply-To: <15460.50887.161245.222054@argo.ozlabs.ibm.com>; from paulus@samba.org on Sat, Feb 09, 2002 at 05:50:47PM +1100
On Sat, Feb 09, 2002 at 05:50:47PM +1100, Paul Mackerras wrote:
> Val Henson writes:
> >
> > The heartbeat function will not execute properly on Gemini without
> > this patch. (Check for cpu 0 removed from gemini_heartbeat.)
>
> CHRP needs the heartbeat function called on all cpus, IIRC.
>
> Clearly the heartbeat_count needs to be per-cpu or else pushed into
> the heartbeat function. How about we make it just
>
> if (ppc_md.heartbeat)
> ppc_md.heartbeat();
>
> and let the heartbeat function do the if (!smp_processor_id()) and the
> if (!heartbeat_count--) if it wants?
Ah, I see, the heartbeat_count is now being decremented once per timer
interrupt, instead of smp_nr_cpus times per timer interrupt. Last
time I checked, it was still possible for the heartbeat count to go
negative.
It's fine the way it is. Sorry for the unnecessary patch.
-VAL
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2002-02-10 0:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-09 1:46 [PATCH] fix heartbeat Val Henson
2002-02-09 6:50 ` Paul Mackerras
2002-02-10 0:23 ` Val Henson [this message]
2002-02-10 21:43 ` Val Henson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020209172353.A32151@boardwalk \
--to=val@nmt.edu \
--cc=linuxppc-dev@lists.linuxppc.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).