From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Sat, 9 Feb 2002 17:23:53 -0700 From: Val Henson To: Paul Mackerras Cc: linuxppc-dev@lists.linuxppc.org Subject: Re: [PATCH] fix heartbeat Message-ID: <20020209172353.A32151@boardwalk> References: <20020208184610.E28166@boardwalk> <15460.50887.161245.222054@argo.ozlabs.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <15460.50887.161245.222054@argo.ozlabs.ibm.com>; from paulus@samba.org on Sat, Feb 09, 2002 at 05:50:47PM +1100 Sender: owner-linuxppc-dev@lists.linuxppc.org List-Id: On Sat, Feb 09, 2002 at 05:50:47PM +1100, Paul Mackerras wrote: > Val Henson writes: > > > > The heartbeat function will not execute properly on Gemini without > > this patch. (Check for cpu 0 removed from gemini_heartbeat.) > > CHRP needs the heartbeat function called on all cpus, IIRC. > > Clearly the heartbeat_count needs to be per-cpu or else pushed into > the heartbeat function. How about we make it just > > if (ppc_md.heartbeat) > ppc_md.heartbeat(); > > and let the heartbeat function do the if (!smp_processor_id()) and the > if (!heartbeat_count--) if it wants? Ah, I see, the heartbeat_count is now being decremented once per timer interrupt, instead of smp_nr_cpus times per timer interrupt. Last time I checked, it was still possible for the heartbeat count to go negative. It's fine the way it is. Sorry for the unnecessary patch. -VAL ** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/