Missing "#ifdef" in arch/ppc/boot/simple/mics-embedded.c ?

Missing "#ifdef" in arch/ppc/boot/simple/mics-embedded.c ?

[Gerard Basler]

Hi,

I don´t have any experience with embedded-linux and I had a while
until I managed to compile the Kernel for a PPC405GP Walnut
architecture.
I always received a compile error in
arch/ppc/boot/simple/misc-embedded.c
saying that the function "serial_close" (line 228) wasn´t found.
I looked at line 84:

#ifdef CONFIG_SERIAL_CONSOLE
com_port = serial_init(0, bp)"
#endif

and changed

serial_close(com_port);

to

#ifdef CONFIG_SERIAL_CONSOLE
serial_close(com_port);
#endif

Now it compiles but I´m not sure if my changes make any sense.
I think that I made some false settings in xconfig but I have no idea
where.

Greetings

Gerard


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

Re: Missing "#ifdef" in arch/ppc/boot/simple/mics-embedded.c ?

[None Atall]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=us-ascii, Size: 1347 bytes --]


  Probably you have choosen at the xconfig to
setup serial console. This is only if you have
a outer chip that supports this function..
(well thats what I understud from the code).
So just dont select this option.

                      D. Meidanis

--- Gerard Basler <gbasler@ee.ethz.ch> wrote:
>
> Hi,
>
> I don´t have any experience with embedded-linux and
> I had a while
> until I managed to compile the Kernel for a PPC405GP
> Walnut
> architecture.
> I always received a compile error in
> arch/ppc/boot/simple/misc-embedded.c
> saying that the function "serial_close" (line 228)
> wasn´t found.
> I looked at line 84:
>
> #ifdef CONFIG_SERIAL_CONSOLE
> com_port = serial_init(0, bp)"
> #endif
>
> and changed
>
> serial_close(com_port);
>
> to
>
> #ifdef CONFIG_SERIAL_CONSOLE
> serial_close(com_port);
> #endif
>
> Now it compiles but I´m not sure if my changes make
> any sense.
> I think that I made some false settings in xconfig
> but I have no idea
> where.
>
> Greetings
>
> Gerard
>
>
>


=====
-------------------------------------------------
  Dhmhtrios Meidanis
-Degree in Mathematics, University of the Aegean.
-Master in Computer Architecture and Digital
 Systems, University of Crete.
  Greece.
-------------------------------------------------


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

Re: Missing "#ifdef" in arch/ppc/boot/simple/mics-embedded.c ?

[Tom Rini]

On Tue, Feb 19, 2002 at 11:27:40AM +0100, Gerard Basler wrote:

> I don?t have any experience with embedded-linux and I had a while
> until I managed to compile the Kernel for a PPC405GP Walnut
> architecture.
> I always received a compile error in
> arch/ppc/boot/simple/misc-embedded.c
> saying that the function "serial_close" (line 228) wasn?t found.
> I looked at line 84:

IIRC, a few months back, compiling w/o CONFIG_SERIAL_CONSOLE wouldn't
even link the kernel.  If it's going that far now, I'll go and apply
what you said later today (it is correct, btw).

--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/