From: David Gibson <david@gibson.dropbear.id.au>
To: Armin Kuster <akuster@mvista.com>
Cc: linuxppc-embedded@lists.linuxppc.org
Subject: ppc405_dma warnings
Date: Thu, 14 Mar 2002 13:21:46 +1100 [thread overview]
Message-ID: <20020314022146.GP22020@zax> (raw)
Armin,
ppc405_dma.c has several constructs like:
p_dma_ch->polarity = polarity & GET_DMA_POLARITY(0);
where GET_DMA_POLARITY() is defined:
#define GET_DMA_POLARITY(chan) DMAReq##chan##_ActiveLow | \
DMAAck##chan##_ActiveLow | EOT##chan##_ActiveLow
Note the macro has no parentheses around its definition, which is
unusual. IIRC C precedence will mean this code turns out as:
p_dma_ch->polarity = (polarity & DMAReq0_ActiveLow) | \
DMAAck0_ActiveLow | EOT0_ActiveLow
which looks wrong to me and if correct is an insane use of a macro.
It's also giving compiler warnings.
I'm guessing that the macro should just get parentheses, but that's a
semantic change so I don't want to make it without knowing for sure.
Could you check this?
--
David Gibson | For every complex problem there is a
david@gibson.dropbear.id.au | solution which is simple, neat and
| wrong. -- H.L. Mencken
http://www.ozlabs.org/people/dgibson
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next reply other threads:[~2002-03-14 2:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-14 2:21 David Gibson [this message]
2002-03-13 21:04 ` ppc405_dma warnings Armin
2002-03-14 6:17 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020314022146.GP22020@zax \
--to=david@gibson.dropbear.id.au \
--cc=akuster@mvista.com \
--cc=linuxppc-embedded@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).