linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Val Henson <val@nmt.edu>
To: linuxppc-dev@lists.linuxppc.org
Subject: Re: [PATCH] Allow OpenPIC irq 0 to be used
Date: Mon, 15 Apr 2002 18:59:54 -0600	[thread overview]
Message-ID: <20020415185954.J17647@boardwalk> (raw)
In-Reply-To: <20020415134322.E15153@boardwalk>; from val@nmt.edu on Mon, Apr 15, 2002 at 01:43:22PM -0600


Hm, in retrospect, I didn't state the actual bug very clearly.  On
Synergy boards, devices can't get interrupts on irq 0 because it is
never initialized.  This patch fixes that, hopefully without
introducing bugs in other boards.

-VAL

On Mon, Apr 15, 2002 at 01:43:22PM -0600, Val Henson wrote:
>
> Synergy boards do not have an i8259 hooked up to irq 0, instead we
> actually use it as a normal irq line.  Yes, I know, bad idea, but
> we're stuck with it.  The following patch is ugly, but illustrates the
> general idea in a way which might possibly be compatible with other
> OpenPIC boards.
>
> -VAL
>
> ===== arch/ppc/kernel/open_pic.c 1.47 vs edited =====
> --- 1.47/arch/ppc/kernel/open_pic.c	Tue Feb  5 03:10:24 2002
> +++ edited/arch/ppc/kernel/open_pic.c	Mon Apr 15 13:42:12 2002
> @@ -366,7 +366,7 @@
>  	}
>
>  	/* Init all external sources */
> -	for (i = 1; i < NumSources; i++) {
> +	for (i = offset ? 1 : 0; i < NumSources; i++) {
>  		int pri, sense;
>
>  		if (ISR[i] == 0)
>

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

      reply	other threads:[~2002-04-16  0:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-15 19:43 [PATCH] Allow OpenPIC irq 0 to be used Val Henson
2002-04-16  0:59 ` Val Henson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020415185954.J17647@boardwalk \
    --to=val@nmt.edu \
    --cc=linuxppc-dev@lists.linuxppc.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).