From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: <mlan@cpu.lu>, <linuxppc-dev@lists.linuxppc.org>
Subject: Re: Problem in pmac PCI fixup
Date: Sun, 28 Apr 2002 17:16:09 +0200 [thread overview]
Message-ID: <20020428151609.30064@smtp.wanadoo.fr> (raw)
In-Reply-To: <E171qYc-0000AJ-00@piglet.grunz.lu>
>--- linux-2.4.19-pre6-lvm-gentoo/arch/ppc/kernel/pmac_pci.c Sun Apr
>28 09:14:09 2002
>+++ linux-2.4.16-planb/arch/ppc/kernel/pmac_pci.c Sun Apr
>28 17:18:39 2002
>@@ -493,8 +503,6 @@
> unsigned char pin;
> struct device_node* node;
>
>- if (pci_read_config_byte(dev, PCI_INTERRUPT_PIN, &pin) ||
>!pin)
>- continue; /* No interrupt generated -> no fixup */
> node = pci_device_to_OF_node(dev);
> if (!node) {
> printk("No OF node for device %x:%x\n", dev->bus-
>>number, dev->devfn >> 3);
>
>Anybody have any problem with that approach?
No problem with that, it's actually what we do in chrp.
Ben.
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2002-04-28 15:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-28 15:25 Problem in pmac PCI fixup Michel Lanners
2002-04-28 15:16 ` Benjamin Herrenschmidt [this message]
2002-04-29 19:34 ` Michel Lanners
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020428151609.30064@smtp.wanadoo.fr \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.linuxppc.org \
--cc=mlan@cpu.lu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).