From: andrew may <acmay@acmay.homeip.net>
To: Armin <akuster@pacbell.net>
Cc: ppc_devel <linuxppc-dev@lists.linuxppc.org>
Subject: Re: 4xx change to core files
Date: Wed, 8 May 2002 10:52:40 -0700 [thread overview]
Message-ID: <20020508105240.A25070@ecam.san.rr.com> (raw)
In-Reply-To: <3CD9560E.9000909@pacbell.net>
On Wed, May 08, 2002 at 09:45:02AM -0700, Armin wrote:
> struct ocp_def core_ocp[] = {
> {UART, UART0_IO_BASE, UART0_INT},
> {UART, UART1_IO_BASE, UART1_INT},
> {IIC, IIC0_BASE, IIC0_IRQ},
> {GPIO, GPIO0_BASE, OCP_IRQ_NA},
> {PCI, PCIL0_BASE, OCP_IRQ_NA},
> {OPB, OPB0_BASE, OCP_IRQ_NA},
> {EMAC, EMAC0_BASE, OCP_IRQ_NA},
> {OCP_NULL_TYPE, 0x0, OCP_IRQ_NA},
>
> };
It would be nice if the global struct ocp_def core_ocp was just a pointer.
Then in a ibm405gp.c and friends could have a static of the entire stucture
and set the global pointer to it.
That should be a pretty straight forward change. The only change to code
that use core_ocp would be maybe a NULL check, but even that could be avoided.
The great thing about these chips is that you can stamp down different OCP's
as needed regaurdless of the actual CPU type.
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
prev parent reply other threads:[~2002-05-08 17:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-08 16:45 4xx change to core files Armin
2002-05-08 17:51 ` Matt Porter
2002-05-08 19:08 ` Armin
2002-05-08 20:27 ` Matt Porter
2002-05-08 17:52 ` andrew may [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020508105240.A25070@ecam.san.rr.com \
--to=acmay@acmay.homeip.net \
--cc=akuster@pacbell.net \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).