From: Tom Rini <trini@kernel.crashing.org>
To: Murray Jensen <Murray.Jensen@csiro.au>
Cc: Rosen Jeremy <Rosen.Jeremy@tms-pty.com>,
linuxppc-embedded@lists.linuxppc.org
Subject: Re: [PATCH] enhanced i2c driver for MPC8xx/MPC8260 CPM ...
Date: Fri, 31 May 2002 07:47:25 -0700 [thread overview]
Message-ID: <20020531144725.GG32412@opus.bloom.county> (raw)
In-Reply-To: <3377.1022808761@msa.cmst.csiro.au>
On Fri, May 31, 2002 at 11:32:41AM +1000, Murray Jensen wrote:
> I think the file that includes <linux/i2c-algo-cpm.h> is expected to include
> commproc.h, or cpm_8260.h, as required. What is the policy on these things?
> Should every include file include all headers it needs? Anyone?
IMHO, a header file should only include other things which the header
itself needs. eg if you do 'u8 foo;' in foo.h, add #include <asm/types.h>
Anything the C file needs itself, it should include, and for the sake of
being explicit (and it's good for multi-arch drivers) if the C code does
'u8 bar;' it should do #include <asm/types.h> too.
> Should we take this discussion off the list now? Cheers!
Nah..
--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2002-05-31 14:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <M2002053110164917692@safemail.tcs-aus.com.au>
2002-05-31 1:32 ` [PATCH] enhanced i2c driver for MPC8xx/MPC8260 CPM Murray Jensen
2002-05-31 14:47 ` Tom Rini [this message]
2002-06-01 2:28 ` Murray Jensen
2002-06-03 14:23 ` Tom Rini
2002-05-31 0:09 Jeremy Rosen
-- strict thread matches above, loose matches on Subject: below --
2002-05-28 5:43 Murray Jensen
2002-05-28 11:01 ` Dan Malek
2002-05-28 11:39 ` Murray Jensen
2002-05-28 13:27 ` Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020531144725.GG32412@opus.bloom.county \
--to=trini@kernel.crashing.org \
--cc=Murray.Jensen@csiro.au \
--cc=Rosen.Jeremy@tms-pty.com \
--cc=linuxppc-embedded@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).