From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 31 May 2002 07:47:25 -0700 From: Tom Rini To: Murray Jensen Cc: Rosen Jeremy , linuxppc-embedded@lists.linuxppc.org Subject: Re: [PATCH] enhanced i2c driver for MPC8xx/MPC8260 CPM ... Message-ID: <20020531144725.GG32412@opus.bloom.county> References: <3377.1022808761@msa.cmst.csiro.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <3377.1022808761@msa.cmst.csiro.au> Sender: owner-linuxppc-embedded@lists.linuxppc.org List-Id: On Fri, May 31, 2002 at 11:32:41AM +1000, Murray Jensen wrote: > I think the file that includes is expected to include > commproc.h, or cpm_8260.h, as required. What is the policy on these things? > Should every include file include all headers it needs? Anyone? IMHO, a header file should only include other things which the header itself needs. eg if you do 'u8 foo;' in foo.h, add #include Anything the C file needs itself, it should include, and for the sake of being explicit (and it's good for multi-arch drivers) if the C code does 'u8 bar;' it should do #include too. > Should we take this discussion off the list now? Cheers! Nah.. -- Tom Rini (TR1265) http://gate.crashing.org/~trini/ ** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/