From: David Gibson <david@gibson.dropbear.id.au>
To: Armin Kuster <akuster@mvista.com>
Cc: linuxppc-embedded@lists.linuxppc.org, Paul Mackerras <paulus@samba.org>
Subject: ppc4xx_pm.c
Date: Tue, 11 Jun 2002 14:39:26 +1000 [thread overview]
Message-ID: <20020611043926.GW25800@zax> (raw)
I've just been looking at this file. As far as I can tell it's almost
completely pointless. First most of the interesting stuff is only
enabled with CONFIG_APM, which is an x86 specific config option,
instead of CONFIG_PM. If CONFIG_APM ever was defined it wouldn't
compile. Second the callback function registered by pm_register()
does nothing except demultiplex the power management callback, we have
no default power management stuff. The only thing which uses it is
the GPIO driver. Anything which wants to do power management might as
well call pm_register() directly itself.
The only function with any use at all is ppc4xx_pm_init(), which
should probably move into ppc4xx_setup.c. Also a bunch of the #ifdefs
could be removed from it - just turn most things off here, then the
driver can turn them back on when it starts.
--
David Gibson | For every complex problem there is a
david@gibson.dropbear.id.au | solution which is simple, neat and
| wrong. -- H.L. Mencken
http://www.ozlabs.org/people/dgibson
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
reply other threads:[~2002-06-11 4:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020611043926.GW25800@zax \
--to=david@gibson.dropbear.id.au \
--cc=akuster@mvista.com \
--cc=linuxppc-embedded@lists.linuxppc.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).