linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: linuxppc-embedded@lists.linuxppc.org
Cc: Paul Mackerras <paulus@samba.org>
Subject: consistent_free()
Date: Fri, 14 Jun 2002 14:29:28 +1000	[thread overview]
Message-ID: <20020614042928.GK26146@zax> (raw)


In attempting to make consistent_alloc/free() work sensibly on
processors which are cache coherent I ran into a problem.
consistent_free() doesn't take a size argument.  We don't need it in
the case of not cache coherent processors - in that case
consistent_alloc() sets up a vm_area() so there's enough information
to get the size.  However for cache coherent processors we probably
want consistent_alloc() to degenerate to __get_free_pages(), in which
case consistent_free() must degenerate to free_pages(), which takes a
size argument.

I suggest we change consistent_free() to take the virtual addresss,
size and the physical address (dma_addr_t), which will make our
consistent_free() match the one on ARM.  I know we don't need the
third argument in any existing situation.

Patch coming...

--
David Gibson			| For every complex problem there is a
david@gibson.dropbear.id.au	| solution which is simple, neat and
				| wrong.  -- H.L. Mencken
http://www.ozlabs.org/people/dgibson

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

             reply	other threads:[~2002-06-14  4:29 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-14  4:29 David Gibson [this message]
2002-06-14  5:57 ` consistent_free() David Gibson
2002-06-24  2:15   ` consistent_free() David Gibson
2002-06-25 14:39     ` consistent_free() Tom Rini
2002-06-26  5:17       ` consistent_free() David Gibson
2002-06-26  5:33         ` consistent_free() Dan Malek
2002-06-26  5:59           ` consistent_free() David Gibson
2002-06-26 14:32         ` consistent_free() Paul Mackerras
2002-06-27  2:42           ` consistent_free() David Gibson
2002-06-14 15:39 ` consistent_free() Tom Rini
2002-06-14 16:44   ` consistent_free() Dan Malek
2002-06-14 17:10     ` consistent_free() Tom Rini
2002-06-14 21:34       ` consistent_free() Dan Malek
2002-06-15  6:11     ` consistent_free() Paul Mackerras
2002-06-15  6:42       ` consistent_free() Dan Malek
2002-06-15 10:02         ` consistent_free() Paul Mackerras
2002-06-15 13:51           ` consistent_free() Dan Malek
2002-06-15  6:02   ` consistent_free() Paul Mackerras
2002-06-15  6:27     ` consistent_free() Dan Malek
2002-06-15  6:57       ` consistent_free() David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020614042928.GK26146@zax \
    --to=david@gibson.dropbear.id.au \
    --cc=linuxppc-embedded@lists.linuxppc.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).