linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Samuel Rydh <samuel@ibrium.se>, <linuxppc-dev@lists.linuxppc.org>
Subject: Re: sycall asm inline
Date: Wed, 19 Jun 2002 05:24:00 +0200	[thread overview]
Message-ID: <20020619032400.8069@smtp.wanadoo.fr> (raw)
In-Reply-To: <20020616145129.GA11923@ibrium.se>


>where __syscall_clobbers is just r4-r12. At a later point, some syscalls
>are instantiated as inline functions:
>
>	static inline _syscall3(int,read,int,fd,char *,buf,off_t,count)
>
>Of course, as long as the syscall reside in a separate function,
>the ABI guarantees that nothing bad will happen. But when the
>function is inlined the undeclared side effects could cause problems,
>or am I missing something?

Probably not missing anything. Now we have to figure the proper set
of clobbers, though I'm wondering if we could replace those inline
syscalls by direct calls to the proper sys_xxx function. The only
advantage I see in doing the syscall from the kernel is that you
can "patch" it from a module or whatever, but is this feature used at
all ?

Ben.


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

  reply	other threads:[~2002-06-19  3:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-16 14:51 sycall asm inline Samuel Rydh
2002-06-19  3:24 ` Benjamin Herrenschmidt [this message]
2002-06-20  1:07   ` Gabriel Paubert
2002-06-19  3:39     ` Benjamin Herrenschmidt
2002-06-20 13:46       ` Gabriel Paubert
2002-06-20 15:18         ` Tom Rini
2002-06-20 15:32           ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020619032400.8069@smtp.wanadoo.fr \
    --to=benh@kernel.crashing.org \
    --cc=linuxppc-dev@lists.linuxppc.org \
    --cc=samuel@ibrium.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).