From: David Gibson <david@gibson.dropbear.id.au>
To: Armin Kuster <akuster@mvista.com>
Cc: linuxppc-embedded@lists.linuxppc.org
Subject: Trivial cleanup in ocp_uart.c
Date: Thu, 20 Jun 2002 17:34:40 +1000 [thread overview]
Message-ID: <20020620073440.GC20689@zax> (raw)
ocp_uart.c allocates private space with ocp_alloc_dev, but never uses
it.
diff -urN /home/dgibson/kernel/linuxppc_2_4_devel/arch/ppc/kernel/ocp_uart.c linux-grinch/arch/ppc/kernel/ocp_uart.c
--- /home/dgibson/kernel/linuxppc_2_4_devel/arch/ppc/kernel/ocp_uart.c Wed Jun 19 10:32:59 2002
+++ linux-grinch/arch/ppc/kernel/ocp_uart.c Thu Jun 20 17:32:57 2002
@@ -99,7 +99,7 @@
int curr_uart = 0;
while (curr_uart != -ENXIO) {
- if (!(uart_drv = ocp_alloc_dev(sizeof (struct serial_struct))))
+ if (!(uart_drv = ocp_alloc_dev(0)))
return -ENOMEM;
uart_drv->type = UART;
/* this returns the next uart number */
--
David Gibson | For every complex problem there is a
david@gibson.dropbear.id.au | solution which is simple, neat and
| wrong. -- H.L. Mencken
http://www.ozlabs.org/people/dgibson
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next reply other threads:[~2002-06-20 7:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-20 7:34 David Gibson [this message]
2002-06-20 15:50 ` Trivial cleanup in ocp_uart.c Tom Rini
2002-06-21 0:52 ` David Gibson
2002-06-21 14:39 ` Tom Rini
2002-06-24 7:40 ` David Gibson
2002-06-26 17:27 ` Scott Anderson
2002-06-27 0:41 ` David Gibson
2002-06-27 16:23 ` Scott Anderson
2002-06-27 16:52 ` Kenneth Johansson
2002-06-28 0:59 ` David Gibson
2002-06-28 14:57 ` Tom Rini
2002-06-27 21:21 ` Armin Kuster
2002-06-27 20:30 ` Paul Mackerras
2002-06-27 21:12 ` Kenneth Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020620073440.GC20689@zax \
--to=david@gibson.dropbear.id.au \
--cc=akuster@mvista.com \
--cc=linuxppc-embedded@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).