From: Tom Rini <trini@kernel.crashing.org>
To: Armin Kuster <akuster@mvista.com>,
linuxppc-embedded@lists.linuxppc.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: Trivial cleanup in ocp_uart.c
Date: Thu, 20 Jun 2002 08:50:26 -0700 [thread overview]
Message-ID: <20020620155026.GE16052@opus.bloom.county> (raw)
In-Reply-To: <20020620073440.GC20689@zax>
On Thu, Jun 20, 2002 at 05:34:40PM +1000, David Gibson wrote:
> ocp_uart.c allocates private space with ocp_alloc_dev, but never uses
> it.
Er... So you pass 0 to ocp_alloc_dev() ? Which will allocate
(sizeof(*ocp_dev) + 0 + 31), so we don't actually break out of this
loop which I take it was your intent.
And I think it can be used, once it gets registered to the ocp_list (and
something later accesses it).
--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2002-06-20 15:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-20 7:34 Trivial cleanup in ocp_uart.c David Gibson
2002-06-20 15:50 ` Tom Rini [this message]
2002-06-21 0:52 ` David Gibson
2002-06-21 14:39 ` Tom Rini
2002-06-24 7:40 ` David Gibson
2002-06-26 17:27 ` Scott Anderson
2002-06-27 0:41 ` David Gibson
2002-06-27 16:23 ` Scott Anderson
2002-06-27 16:52 ` Kenneth Johansson
2002-06-28 0:59 ` David Gibson
2002-06-28 14:57 ` Tom Rini
2002-06-27 21:21 ` Armin Kuster
2002-06-27 20:30 ` Paul Mackerras
2002-06-27 21:12 ` Kenneth Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020620155026.GE16052@opus.bloom.county \
--to=trini@kernel.crashing.org \
--cc=akuster@mvista.com \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-embedded@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).