Re: [PATCH/RFC] Change how we pick which _kd_mksound to use.

[Tom Rini <trini@kernel.crashing.org>]

On Mon, Jul 08, 2002 at 09:07:39AM -0700, Armin wrote:

> Paul Mockeries wrote:
>
> >Tom Rind writes:
> >
> >>The following changes how we pick a _kd_mksound.  The problem is that on
> >>some machines, such as IBM405, the default _kd_mksound breaks horribly
> >>due to the inb/outb's attempting to fiddle with timers which don't
> >>exist.  This changes the test which selects either an empty _kd_mksound
> >>or the one in question from __powerpc__ to CONFIG_PPC64 (since from what I
> >>understand, __powerpc__ is defined on ppc64) || (CONFIG_PPC32 &&
> >>CONFIG_6xx).  The CONFIG_6xx test is because these boards are the ones
> >>which tend to have a SuperIO chip, or something else with the timers at
> >>0x61, 0xB6, etc.
> >>
> >>The other option would be to define an empty no_kd_mksound or so on
> >>4xx/8xx and then conditionally set kd_mksound to that, but I would
> >>prefer this since we're already doing some preprocessor checks anyhow.
> >>
> It looks to me as if the CONFIG_REDWOOD should be changed to CONFIG_4XX
> to start with and there are no guarantees that the timer will be at the
> same locations plus on a pci base 4xx , in*/out* can't br used on local
> bus i/o access.

Well, CONFIG_REDWOOD should be changed into something that catches all
of the other boards that it won't work on. :)

> >This is one of those "there's got to be a better way" places.  The
> >CONFIG_PPC32 && CONFIG_6xx test doesn't really capture what we want
> >much better than the existing __powerpc__ test does.  Testing
> >CONFIG_PPC32 && CONFIG_ISA might go closer.  I would really rather
> >that _kd_mksound was provided in the platform-specific files on those
> >platforms where it applies, though.
>
> For 4xx it should be defined at the board level in most cases :)

Right, just how pmac case is done.  If we want/can have the beep on a
4xx board :)

--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/