From: Matt Porter <porter@cox.net>
To: Dan Malek <dan@embeddededge.com>
Cc: David Gibson <david@gibson.dropbear.id.au>,
linuxppc-embedded@lists.linuxppc.org
Subject: Re: consistent_alloc() revisited
Date: Tue, 16 Jul 2002 08:27:26 -0700 [thread overview]
Message-ID: <20020716082726.B3654@home.com> (raw)
In-Reply-To: <3D3428FF.5090401@embeddededge.com>; from dan@embeddededge.com on Tue, Jul 16, 2002 at 10:09:03AM -0400
On Tue, Jul 16, 2002 at 10:09:03AM -0400, Dan Malek wrote:
>
> David Gibson wrote:
> > - if (in_interrupt())
> > - BUG();
> > + BUG_ON(in_interrupt());
>
> We should be able to call these functions from interrupt, let's push
> the remainder of the changes though get_free_pages() to make this happen.
Yes, not just "should", but "must". They must be callable from an
interrupt since many generic drivers follow the rules as they have
been laid down and allocate from an interrupt context.
Regards,
--
Matt Porter
porter@cox.net
This is Linux Country. On a quiet night, you can hear Windows reboot.
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2002-07-16 15:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-16 2:13 consistent_alloc() revisited David Gibson
2002-07-16 14:09 ` Dan Malek
2002-07-16 14:58 ` Tom Rini
2002-07-16 15:23 ` Matt Porter
2002-07-16 15:27 ` Matt Porter [this message]
2002-07-17 1:24 ` David Gibson
2002-07-20 15:28 ` Benjamin Herrenschmidt
2002-07-21 13:26 ` David Gibson
2002-07-20 15:22 ` Benjamin Herrenschmidt
2002-07-21 13:23 ` David Gibson
-- strict thread matches above, loose matches on Subject: below --
2002-07-16 16:14 Ralph Blach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020716082726.B3654@home.com \
--to=porter@cox.net \
--cc=dan@embeddededge.com \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-embedded@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).