From: Matt Porter <porter@cox.net>
To: Tom Rini <trini@kernel.crashing.org>
Cc: linuxppc-dev <linuxppc-dev@lists.linuxppc.org>
Subject: Re: [RFC/PATCH] idle loop changes
Date: Wed, 31 Jul 2002 14:24:01 -0700 [thread overview]
Message-ID: <20020731142401.B5793@home.com> (raw)
In-Reply-To: <20020731193200.GD17472@opus.bloom.county>; from trini@kernel.crashing.org on Wed, Jul 31, 2002 at 12:32:00PM -0700
On Wed, Jul 31, 2002 at 12:32:00PM -0700, Tom Rini wrote:
>
> The following is based on the final patch that Armin posted a short
> while back. What this does is allow for the power_save() function to be
> overridden, but still provide a 'sane' default. This moves the existing
> power_save() function into ppc6xx_idle.c, as after talking with Hollis,
> the function won't work as-is on Power3/iSeries (bits have moved or are
> non-existant).
>
> I'm not totally sure if it's better to do it this way, or to not provide
> a default power_save(), so that if we don't set pm_idle to something, we
> just never call power_save() (as opposed to a call, check for a bit &
> return). Comments?
To build it on non-6xx you need to move the powersave_nap declaration
back to idle.c and extern it in ppc6xx_idle.c. It's required by
sysctl. Other than that, this will work.
Regards,
--
Matt Porter
porter@cox.net
This is Linux Country. On a quiet night, you can hear Windows reboot.
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2002-07-31 21:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-31 19:32 [RFC/PATCH] idle loop changes Tom Rini
2002-07-31 20:25 ` Dan Malek
2002-07-31 20:38 ` Tom Rini
2002-07-31 20:41 ` Tom Rini
2002-07-31 21:33 ` Matt Porter
2002-07-31 21:29 ` Dan Malek
2002-07-31 21:48 ` Mark A. Greer
2002-07-31 22:23 ` Dan Malek
2002-08-01 0:11 ` Tom Rini
2002-07-31 21:24 ` Matt Porter [this message]
2002-08-01 0:09 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020731142401.B5793@home.com \
--to=porter@cox.net \
--cc=linuxppc-dev@lists.linuxppc.org \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).