From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 31 Jul 2002 14:24:01 -0700 From: Matt Porter To: Tom Rini Cc: linuxppc-dev Subject: Re: [RFC/PATCH] idle loop changes Message-ID: <20020731142401.B5793@home.com> References: <20020731193200.GD17472@opus.bloom.county> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20020731193200.GD17472@opus.bloom.county>; from trini@kernel.crashing.org on Wed, Jul 31, 2002 at 12:32:00PM -0700 Sender: owner-linuxppc-dev@lists.linuxppc.org List-Id: On Wed, Jul 31, 2002 at 12:32:00PM -0700, Tom Rini wrote: > > The following is based on the final patch that Armin posted a short > while back. What this does is allow for the power_save() function to be > overridden, but still provide a 'sane' default. This moves the existing > power_save() function into ppc6xx_idle.c, as after talking with Hollis, > the function won't work as-is on Power3/iSeries (bits have moved or are > non-existant). > > I'm not totally sure if it's better to do it this way, or to not provide > a default power_save(), so that if we don't set pm_idle to something, we > just never call power_save() (as opposed to a call, check for a bit & > return). Comments? To build it on non-6xx you need to move the powersave_nap declaration back to idle.c and extern it in ppc6xx_idle.c. It's required by sysctl. Other than that, this will work. Regards, -- Matt Porter porter@cox.net This is Linux Country. On a quiet night, you can hear Windows reboot. ** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/