From: Wolfgang Denk <wd@denx.de>
To: bart@ardistech.com
Cc: govindan@india.tejasnetworks.com, svacca@valcom.com,
"LinuxEmbeddedMailList (E-mail)"
<linuxppc-embedded@lists.linuxppc.org>,
govindan@tejasnetworks.com
Subject: Re: Execute Reset via CheckStop approach
Date: Fri, 23 Aug 2002 15:36:48 +0200 [thread overview]
Message-ID: <20020823133653.7604B11822@denx.denx.de> (raw)
In-Reply-To: Your message of "Fri, 23 Aug 2002 15:23:40 +0200." <3D66375C.2046CFA9@ardistech.com>
Hi,
in message <3D66375C.2046CFA9@ardistech.com> you wrote:
>
> I cleared CFG_DER in ppcboot to clear the CHSTP bit. After that I needed to
> map in the br0 range and to make the asm's volatile and set the input/output
Why do you think you have to do this? This is _NOT_ necessary.
> parameters of the asm to get the HRESET_N pulse. So this is the version
> which works (on a MPC823e) in the context of the Linux kernel:
>
> /* Get base address mapped by BR0/OR0 and map it in */
> val = ((immap_t *)IMAP_ADDR)->im_memctl.memc_br0 & 0xFFFF8000;
> val = (int) ioremap( retval, 0x4000 );
This code is wrong. You clobber the value of "val" here.
Wolfgang Denk
--
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd@denx.de
Defaults are wonderful, just like fire.
- Larry Wall in <1996Mar6.004121.27890@netlabs.com>
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2002-08-23 13:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3D6612BA.730D7A25@ardistech.com>
2002-08-23 11:33 ` Execute Reset via CheckStop approach Wolfgang Denk
2002-08-23 13:23 ` bart
2002-08-23 13:36 ` Wolfgang Denk [this message]
2002-07-23 13:45 Steven Vacca
2002-07-23 13:54 ` Wolfgang Denk
2002-07-24 5:19 ` Govindan
2002-07-24 15:46 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020823133653.7604B11822@denx.denx.de \
--to=wd@denx.de \
--cc=bart@ardistech.com \
--cc=govindan@india.tejasnetworks.com \
--cc=govindan@tejasnetworks.com \
--cc=linuxppc-embedded@lists.linuxppc.org \
--cc=svacca@valcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).