From: Wolfgang Denk <wd@denx.de>
To: joakim.tjernlund@lumentis.se
Cc: "Michael Meriin" <Michael@KSWaves.com>,
"linuxppc-embedded" <linuxppc-embedded@lists.linuxppc.org>
Subject: Re: SPI Driver for 8xx
Date: Wed, 11 Sep 2002 12:50:33 +0200 [thread overview]
Message-ID: <20020911105038.2375DFA8B@denx.denx.de> (raw)
In-Reply-To: Your message of "Wed, 11 Sep 2002 12:26:20 +0200." <IGEFJKJNHJDCBKALBJLLAEFNFGAA.joakim.tjernlund@lumentis.se>
Dear Jocke,
in message <IGEFJKJNHJDCBKALBJLLAEFNFGAA.joakim.tjernlund@lumentis.se> you wrote:
> Great, I too need a SPI driver for mpc8xx.
:-)
> I took a quick look at the cpm_spi.* driver and looks fine to me, but I have a question:
> The driver turns off interrupts during transmission. The comment in the file
> says: ... we may need to call it from interrupt handlers.
>
> I can not see any call from a interrupt handler in this code. Where is the call(s) from/to
> interrupt handlers? Or is this just a future extension?
We use the SPI communication inside another device driver (for CAN
bus). It is this other driver that will call the SPI I/O function in
it's interrupt handler.
> I would like to keep the interrupts on, if possible.
Feel free to modify the driver according to your needs. It should not
be a problem except for special cases like ours.
Wolfgang Denk
--
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd@denx.de
"If the code and the comments disagree, then both are probably
wrong." - Norm Schryer
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next parent reply other threads:[~2002-09-11 10:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <IGEFJKJNHJDCBKALBJLLAEFNFGAA.joakim.tjernlund@lumentis.se>
2002-09-11 10:50 ` Wolfgang Denk [this message]
2002-09-11 8:27 SPI Driver for 8xx Michael Meriin
2002-09-11 7:48 ` Wolfgang Denk
2002-09-11 8:58 ` Michael Meriin
2002-09-11 8:28 ` Wolfgang Denk
2002-09-11 9:34 ` Michael Meriin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020911105038.2375DFA8B@denx.denx.de \
--to=wd@denx.de \
--cc=Michael@KSWaves.com \
--cc=joakim.tjernlund@lumentis.se \
--cc=linuxppc-embedded@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).