From: Mark Chambers <markc@mail.com>
To: linuxppc-dev@lists.linuxppc.org
Subject: undefined IRQs in request_irq
Date: Wed, 18 Sep 2002 10:39:47 -0400 [thread overview]
Message-ID: <200209181039.47488.markc@mail.com> (raw)
I wrote a driver for our custom MPC860 platform that we've ported linux 2.4.19
to. When I insmod'd the driver it produced a kernel panic. I traced it to
request_irq() in ppc8xx_pic.c, where the code calls panic() if the requested
irq is anything other than IDEx_INTERRUPT. I fixed my problem by just adding
another case.
First, it seems extreme to me to crash the system instead of just refusing the
request. Am I missing something?
Second, a suggested improvement: How about having the individual board.h
files include #defines like ENABLE_SIU_LEVEL1, etc. that could be used like
the 'well known' IDEx_INTERRUPTs in request_irq()?
Mark Chambers
Microfirst, Inc.
mchambers@microfirst.com
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next reply other threads:[~2002-09-18 14:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-18 14:39 Mark Chambers [this message]
2002-09-19 0:49 ` undefined IRQs in request_irq Paul Mackerras
2002-09-19 13:46 ` Allen Curtis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200209181039.47488.markc@mail.com \
--to=markc@mail.com \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).