Re: linuxppc_2_4_devel patch: 8xx FEC extensions

[Wolfgang Denk <wd@denx.de>]

[-- Attachment #1: Type: text/plain, Size: 1760 bytes --]

In message <20021223151254.GC15397@opus.bloom.county> you wrote:
>
> > It makes the following modifications to the MPC8xx FEC driver:
> >
> > - change PHY configuration from #define to kernel config mechanism
> > - add support for AMD79C874 PHY
>
> Both of these look OK, but can you please split this out into a seperate
> patch which just does PHY configuration and then adds AMD79C874 support?

Of course I can.

PHY configuration ==> patch.1
add AMD79C874 support ==> patch.2

> > - add multicast support
>
> Sounds fine, but can you split this portion of the code from the rest of
> the patch please?  Thanks.

Of course I can.

cleanup & add multicast support ==> patch.3



But really, why do I have to do this?

I'm pretty sure you can read the patch as  is  so  you  are  able  to
either  complain about stuff you don't like or to accept these things
in one patch. Is this just some form  of  bullying,  or  is  there  a
rational reason behind this requirement?


> > - add PACKETHOOK support
>
> This was removed, intentionally back on March 22nd, 2002.  From what I
> recall, it was decided this code was broken / unmaintained and should be
> yanked.  Have you tested this particular section of code to verify it
> still compiles and works as expected?
>
> In sum: On hold for now.

If that was a decision I'm not in the  position  to  discuss  such  a
things. Just forget it.



Wolfgang Denk

--
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd@denx.de
The complexity of software is an essential property, not an  acciden-
tal  one. Hence, descriptions of a software entity that abstract away
its complexity often abstract away its essence.    - Fred Brooks, Jr.


[-- Attachment #2: 8xx-fec.patches.tar.gz --]
[-- Type: application/x-gzip , Size: 7964 bytes --]