From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 9 Jan 2003 10:49:08 +1100 From: David Gibson To: Hollis Blanchard Cc: paulus@samba.org, devel list Subject: Re: get_pteptr prototype Message-ID: <20030108234908.GA1088@zax.zax> References: <1041893967.1207.42.camel@granite.austin.ibm.com> <20030107005751.GP22215@zax.zax> <1042040929.1021.80.camel@granite.austin.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1042040929.1021.80.camel@granite.austin.ibm.com> Sender: owner-linuxppc-dev@lists.linuxppc.org List-Id: On Wed, Jan 08, 2003 at 09:48:48AM -0600, Hollis Blanchard wrote: > > On Mon, 2003-01-06 at 18:57, David Gibson wrote: > > > > On Mon, Jan 06, 2003 at 04:59:26PM -0600, Hollis Blanchard wrote: > > > Hi, I think the prototype for get_pteptr should be moved to > > > asm/pgtable.h . It currently is declared extern in mm/fault.c, and I > > > will need it for platforms/ibm405lp_pm.c . > > > > > > Please apply to _2_4_devel and -2.5, and probably _2_4 for that matter. > > > > Hrm... what are you actually intending to use get_pteptr() for. > > I use it to acquire the PTE pointer for a page I need to mark writable > (see the init function in > http://penguinppc.org/~hollis/405LP-sleep.diff). It's sort of like > CONFIG_XMON mapping the whole kernel writable, except I only need one > page. If you know of a better way, please let me know! > > > There > > are currently only two users, one of which needs to die (in 2.5, at > > least). My experience has been that the concept of get_pteptr() is a > > great deal less useful that one would, at first, think. > > It's simply a wrapper around successive pte/pmd/pgd_offset calls, with > some error checking. Are you saying those calls are not the correct way > to get the PTE pointer for an address? Trouble is that this will break badly in 2.5 where we use large-page entries for the lowmem mapping. -- David Gibson | For every complex problem there is a david@gibson.dropbear.id.au | solution which is simple, neat and | wrong. http://www.ozlabs.org/people/dgibson ** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/