Re: Generic RTC driver in 2.4.x

[Helge Deller <deller@gmx.de>]

[-- Attachment #1: Type: text/plain, Size: 867 bytes --]

On Sunday 12 January 2003 12:33, Geert Uytterhoeven wrote:
> I made some more changes afterwards:
>   - Add forward declaration for gen_rtc_interrupt()

This one should be moved inside the #ifdef CONFIG_GEN_RTC_X section to
avoid "genrtc.c:69: warning: `gen_rtc_interrupt' declared `static' but never defined"
warnings. Please see attached patch.

Or, you could just move the declaration of gen_rtc_interrupt() above the one
from genrtc_troutine(), in which case we wouldn't need the forward declaration at all.

> BTW, perhaps we should move the global RTC_* definitions in <asm/rtc.h> to
> <linux/genrtc.h>, or merge them with the ones in <linux/mc146818rtc.h> and
> move them to <linux/rtc.h>?

IMHO leaving them architecture specific in <asm/rtc.h> seems best to me, and it
leaves the most possibilities to make them later more dependend on the hardware.

Helge


[-- Attachment #2: diff --]
[-- Type: text/plain, Size: 571 bytes --]

--- ./genrtc.c.geert	Sun Jan 12 13:16:40 2003
+++ ./genrtc.c	Sun Jan 12 13:15:18 2003
@@ -66,9 +66,6 @@

 static DECLARE_WAIT_QUEUE_HEAD(gen_rtc_wait);

-static void gen_rtc_interrupt(unsigned long arg);
-
-
 /*
  *	Bits in gen_rtc_status.
  */
@@ -99,6 +96,8 @@
 static int stop_rtc_timers;                    /* don't requeue tasks */
 static spinlock_t gen_rtc_lock = SPIN_LOCK_UNLOCKED;

+static void gen_rtc_interrupt(unsigned long arg);
+
 /*
  * Routine to poll RTC seconds field for change as often as posible,
  * after first RTC_UIE use timer to reduce polling