pmac: input layer as module and usb keyboard

pmac: input layer as module and usb keyboard

[Magnus Damm]

[-- Attachment #1: Type: text/plain, Size: 156 bytes --]

Hi all,

This patch makes it possible to use a usb keyboard with a kernel that has the
input layer compiled as a module.

Please apply.

thanks /

magnus



[-- Attachment #2: linux-2.4.20-pmac_input_module.patch --]
[-- Type: application/octet-stream, Size: 490 bytes --]

--- linux-2.4.20/arch/ppc/platforms/pmac_setup.c	2002-11-28 23:53:11.000000000 +0000
+++ linux-2.4.20-pmac_input_module/arch/ppc/platforms/pmac_setup.c	2003-02-09 14:48:55.000000000 +0000
@@ -851,7 +851,7 @@
 select_adb_keyboard(void)
 {
 #ifdef CONFIG_VT
-#ifdef CONFIG_INPUT
+#if defined(CONFIG_INPUT) || defined(CONFIG_INPUT_MODULE)
 	ppc_md.kbd_init_hw       = mac_hid_init_hw;
 	ppc_md.kbd_translate     = mac_hid_kbd_translate;
 	ppc_md.kbd_unexpected_up = mac_hid_kbd_unexpected_up;

Re: pmac: input layer as module and usb keyboard

[Benjamin Herrenschmidt]

On Sun, 2003-02-09 at 22:30, Magnus Damm wrote:
> Hi all,
>
> This patch makes it possible to use a usb keyboard with a kernel that has the
> input layer compiled as a module.
>
> Please apply.

Well, I tend to hate CONFIG_*_MODULE. The kernel itself shouldn't
be affected by a subsystem or driver beeing a module that way. I
need to find out a better way to deal with this problem.

Ben.


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: pmac: input layer as module and usb keyboard

[Magnus Damm]

> > This patch makes it possible to use a usb keyboard with a kernel that has the
> > input layer compiled as a module.
> >
> > Please apply.
>
> Well, I tend to hate CONFIG_*_MODULE. The kernel itself shouldn't
> be affected by a subsystem or driver beeing a module that way. I
> need to find out a better way to deal with this problem.

I agree. But I like the idea of compiling the input layer as a module.
Maybe CONFIG_MAC_HID? Then we put the problem in config.in...

My local 2.4.20 pmac_setup.c has plenty of
#if defined(CONFIG_BLK_DEV_IDE) || defined(CONFIG_BLK_DEV_IDE_MODULE)
so you must be very happy.. =)

thanks.

/ magnus

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: pmac: input layer as module and usb keyboard

[Benjamin Herrenschmidt]

On Sun, 2003-02-09 at 23:33, Magnus Damm wrote:

> My local 2.4.20 pmac_setup.c has plenty of
> #if defined(CONFIG_BLK_DEV_IDE) || defined(CONFIG_BLK_DEV_IDE_MODULE)
> so you must be very happy.. =)

Heh, I want to get rid of those too, though IDE as a module is
known to be broken in various other ways right now anyway.

Ben.


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/