From: Brian Waite <waite@skycomputers.com>
To: linuxppc-dev <linuxppc-dev@lists.linuxppc.org>
Subject: RFC: gt64260 descriptor struct
Date: Thu, 27 Feb 2003 10:31:27 -0500 [thread overview]
Message-ID: <200302271031.27317.waite@skycomputers.com> (raw)
I know this was very briefly discussed in the past but I am in need of doing
this right so lets start up the discussion again.
The gt64260 code relies on many defines and/or fw values when it should not.
For example the MPSC and eth both pull from a define or bi_struct for certain
information. We all agree this is not good. In house I now have 2 new
drivers, i2c and timer 4, that also would like some of this info.
What we need is a global structure for gt code that will describe the features
of the gt and export that to drivers that need it. What I see right now for
required elements are:
typdef struct gt64260_features {
unsigned long mem_size;
unsigned long bus_speed /* in Hz */
unsigned char eth1addr[6];
unsigned char eth2addr[6];
unsigned char eth3addr[6];
unsigned long baudrate;
} gt64260_features_t;
I really would like to hear from other gt developers and anyone else about
this being a good or bad idea. I am not sure we even need all of these
elements in the struct, ie gt64260_base, but I was looking for places we
conditionally look at the bd_t. Any thoughts?
Thanks
Brian
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next reply other threads:[~2003-02-27 15:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-27 15:31 Brian Waite [this message]
2003-02-27 16:27 ` RFC: gt64260 descriptor struct Matt Porter
2003-02-27 18:01 ` Brian Waite
2003-02-27 21:32 ` Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200302271031.27317.waite@skycomputers.com \
--to=waite@skycomputers.com \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).