linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: "Johnson, Stephen" <stevebj@artesyncp.com>
Cc: linuxppc-embedded@lists.linuxppc.org
Subject: Re: Opps...with ELDK-2.1.0 (ppc_4xx)
Date: Wed, 23 Apr 2003 19:14:56 +0200	[thread overview]
Message-ID: <20030423171501.96FD2C5E29@atlas.denx.de> (raw)
In-Reply-To: Your message of "Wed, 23 Apr 2003 08:49:54 CDT." <F9102D41F595D311ACA7009027DE2C840527B19B@c3po.heurikon.com>


In message <F9102D41F595D311ACA7009027DE2C840527B19B@c3po.heurikon.com> you wrote:
>
> i2c is somewhat slow...and I looked at the driver to see it using spin_lock() around the write to the rtc. This could potentially be the problem...and it most likely would not be observed with a memory mapped rtc device (because it is much faster than i2c).


Ummm... can you please try using shorter lines? Some 70...80 chars or
so? Thanks.

> I just changed spin_lock() to spin_lock_irq() and I'm currently testing it.
>
> Wolfgang:  Is the driver that you're seeing the problem with using spin_lock().

No, it is not. We see the problem for example  on  the  LWMON  board,
which uses drivers/char/pcf8563_rtc.c and drivers/i2c/i2c-simple.c.

Best regards,

Wolfgang Denk

--
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd@denx.de
I'm what passes for a Unix guru in my office. This is  a  frightening
concept. - Lee Ann Goldstein, in <3k55ba$c43@butch.lmsc.lockheed.com>

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

       reply	other threads:[~2003-04-23 17:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <F9102D41F595D311ACA7009027DE2C840527B19B@c3po.heurikon.com>
2003-04-23 17:14 ` Wolfgang Denk [this message]
2003-04-23 18:05 Opps...with ELDK-2.1.0 (ppc_4xx) Oliver Amft
     [not found] <F9102D41F595D311ACA7009027DE2C8406AB8214@c3po.heurikon.com >
2003-04-23 17:24 ` Eugene Surovegin
  -- strict thread matches above, loose matches on Subject: below --
2003-04-23 17:18 Montgomery, Tim
2003-04-23 19:18 ` Wolfgang Denk
2003-04-22 19:38 Johnson, Stephen
2003-04-22 19:50 ` Wolfgang Denk
2003-04-22 20:33   ` Eugene Surovegin
     [not found] <F9102D41F595D311ACA7009027DE2C840527B192@c3po.heurikon.com>
2003-04-22 19:16 ` Wolfgang Denk
2003-04-22 15:59 Johnson, Stephen
2003-04-22 16:58 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030423171501.96FD2C5E29@atlas.denx.de \
    --to=wd@denx.de \
    --cc=linuxppc-embedded@lists.linuxppc.org \
    --cc=stevebj@artesyncp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).