* 2.5 and serial console
@ 2003-05-04 16:51 Olaf Hering
2003-05-05 17:25 ` Tom Rini
0 siblings, 1 reply; 9+ messages in thread
From: Olaf Hering @ 2003-05-04 16:51 UTC (permalink / raw)
To: linuxppc-dev
Morning,
is there a fix for this? It seems to involve Makefile tweaking, at least.
ld -T arch/ppc/boot/ld.script -Ttext 0x00800000 -Bstatic -o arch/ppc/boot/prep/zImage arch/ppc/boot/prep/head.o arch/ppc/boot/prep/misc.o arch/ppc/boot/prep
/vreset.o arch/ppc/boot/prep/kbd.o arch/ppc/boot/simple/legacy.o arch/ppc/boot/prep/image.o arch/ppc/boot/common/lib.a arch/ppc/boot/lib/lib.a
arch/ppc/boot/common/lib.a(misc-common.o)(.text+0x92): In function `tstc':
: undefined reference to `com_port'
arch/ppc/boot/common/lib.a(misc-common.o)(.text+0x96): In function `tstc':
: undefined reference to `com_port'
arch/ppc/boot/common/lib.a(misc-common.o)(.text+0x98): In function `tstc':
: undefined reference to `serial_tstc'
arch/ppc/boot/common/lib.a(misc-common.o)(.text+0xaa): In function `tstc':
: undefined reference to `com_port'
arch/ppc/boot/common/lib.a(misc-common.o)(.text+0xae): In function `tstc':
: undefined reference to `com_port'
arch/ppc/boot/common/lib.a(misc-common.o)(.text+0xb0): In function `tstc':
: undefined reference to `serial_tstc'
arch/ppc/boot/common/lib.a(misc-common.o)(.text+0xca): In function `getc':
: undefined reference to `com_port'
arch/ppc/boot/common/lib.a(misc-common.o)(.text+0xd2): In function `getc':
: undefined reference to `com_port'
arch/ppc/boot/common/lib.a(misc-common.o)(.text+0xd4): In function `getc':
: undefined reference to `serial_tstc'
arch/ppc/boot/common/lib.a(misc-common.o)(.text+0x112): In function `getc':
: undefined reference to `com_port'
arch/ppc/boot/common/lib.a(misc-common.o)(.text+0x114): In function `getc':
: undefined reference to `serial_getc'
arch/ppc/boot/common/lib.a(misc-common.o)(.text+0x13a): In function `putc':
: undefined reference to `com_port'
arch/ppc/boot/common/lib.a(misc-common.o)(.text+0x142): In function `putc':
: undefined reference to `com_port'
arch/ppc/boot/common/lib.a(misc-common.o)(.text+0x148): In function `putc':
: undefined reference to `serial_putc'
arch/ppc/boot/common/lib.a(misc-common.o)(.text+0x212): In function `putc':
: undefined reference to `com_port'
arch/ppc/boot/common/lib.a(misc-common.o)(.text+0x218): In function `putc':
: undefined reference to `serial_putc'
arch/ppc/boot/common/lib.a(misc-common.o)(.text+0x252): In function `puts':
: undefined reference to `com_port'
arch/ppc/boot/common/lib.a(misc-common.o)(.text+0x25e): In function `puts':
: undefined reference to `com_port'
arch/ppc/boot/common/lib.a(misc-common.o)(.text+0x264): In function `puts':
: undefined reference to `serial_putc'
arch/ppc/boot/common/lib.a(misc-common.o)(.text+0x312): In function `puts':
: undefined reference to `com_port'
arch/ppc/boot/common/lib.a(misc-common.o)(.text+0x31c): In function `puts':
: undefined reference to `serial_putc'
make[2]: *** [arch/ppc/boot/images/zImage.prep] Error 1
make[1]: *** [prep] Error 2
make: *** [zImage] Error 2
builds@ibook:~/linux-2.5.68> grep -wlr serial_tstc .
./arch/ppc/boot/simple/m8xx_tty.c
./arch/ppc/boot/simple/m8260_tty.c
./arch/ppc/boot/simple/gt64260_tty.c
./arch/ppc/boot/common/misc-common.c
./arch/ppc/boot/common/ns16550.c
./arch/ppc/boot/common/misc-common.o
./arch/ppc/boot/common/lib.a
--
USB is for mice, FireWire is for men!
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: 2.5 and serial console
2003-05-04 16:51 2.5 and serial console Olaf Hering
@ 2003-05-05 17:25 ` Tom Rini
2003-05-05 17:45 ` Olaf Hering
0 siblings, 1 reply; 9+ messages in thread
From: Tom Rini @ 2003-05-05 17:25 UTC (permalink / raw)
To: Olaf Hering; +Cc: linuxppc-dev
On Sun, May 04, 2003 at 06:51:16PM +0200, Olaf Hering wrote:
> Morning,
>
> is there a fix for this? It seems to involve Makefile tweaking, at least.
What .config file?
--
Tom Rini
http://gate.crashing.org/~trini/
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: 2.5 and serial console
2003-05-05 17:25 ` Tom Rini
@ 2003-05-05 17:45 ` Olaf Hering
2003-05-05 19:29 ` Tom Rini
0 siblings, 1 reply; 9+ messages in thread
From: Olaf Hering @ 2003-05-05 17:45 UTC (permalink / raw)
To: Tom Rini; +Cc: linuxppc-dev
On Mon, May 05, Tom Rini wrote:
> On Sun, May 04, 2003 at 06:51:16PM +0200, Olaf Hering wrote:
>
> > Morning,
> >
> > is there a fix for this? It seems to involve Makefile tweaking, at least.
>
> What .config file?
It seems CONFIG_SERIAL_8250_CONSOLE is gone. I can not activate it
anywhere.
CONFIG_MMU=y
CONFIG_RWSEM_XCHGADD_ALGORITHM=y
CONFIG_HAVE_DEC_LOCK=y
CONFIG_EXPERIMENTAL=y
CONFIG_SWAP=y
CONFIG_SYSVIPC=y
CONFIG_SYSCTL=y
CONFIG_LOG_BUF_SHIFT=18
CONFIG_PPC=y
CONFIG_PPC32=y
CONFIG_6xx=y
CONFIG_GENERIC_ISA_DMA=y
CONFIG_ALL_PPC=y
CONFIG_PPC_STD_MMU=y
CONFIG_SERIAL_CONSOLE=y
CONFIG_ALL_PPC_CH=y
CONFIG_PCI=y
CONFIG_KCORE_ELF=y
CONFIG_BINFMT_ELF=y
CONFIG_KERNEL_ELF=y
CONFIG_BINFMT_MISC=y
CONFIG_PPC601_SYNC_FIX=y
CONFIG_PROC_DEVICETREE=y
CONFIG_PPCBUG_NVRAM=y
CONFIG_HIGHMEM_START=0xfe000000
CONFIG_LOWMEM_SIZE=0x30000000
CONFIG_KERNEL_START=0xc0000000
CONFIG_TASK_SIZE=0x80000000
CONFIG_BOOT_LOAD=0x00800000
CONFIG_BLK_DEV_FD=y
CONFIG_BLK_DEV_LOOP=y
CONFIG_BLK_DEV_RAM=y
CONFIG_BLK_DEV_RAM_SIZE=128000
CONFIG_BLK_DEV_INITRD=y
CONFIG_SCSI=y
CONFIG_BLK_DEV_SD=y
CONFIG_BLK_DEV_SR=y
CONFIG_BLK_DEV_SR_VENDOR=y
CONFIG_CHR_DEV_SG=y
CONFIG_SCSI_REPORT_LUNS=y
CONFIG_SCSI_CONSTANTS=y
CONFIG_SCSI_MAC53C94=y
CONFIG_IEEE1394=y
CONFIG_IEEE1394_OHCI1394=y
CONFIG_IEEE1394_SBP2=y
CONFIG_NET=y
CONFIG_PACKET=y
CONFIG_UNIX=y
CONFIG_INET=y
CONFIG_IP_MULTICAST=y
CONFIG_SYN_COOKIES=y
CONFIG_IPV6_SCTP__=y
CONFIG_NETDEVICES=y
CONFIG_NET_ETHERNET=y
CONFIG_MACE=y
CONFIG_FB=y
CONFIG_FB_OF=y
CONFIG_FB_PLATINUM=y
CONFIG_LOGO=y
CONFIG_LOGO_LINUX_MONO=y
CONFIG_LOGO_LINUX_VGA16=y
CONFIG_LOGO_LINUX_CLUT224=y
CONFIG_SOUND_GAMEPORT=y
CONFIG_ADB_CUDA=y
CONFIG_MAC_SERIAL=y
CONFIG_ADB=y
CONFIG_UNIX98_PTYS=y
CONFIG_UNIX98_PTY_COUNT=256
CONFIG_I2C=y
CONFIG_I2C_KEYWEST=y
CONFIG_I2C_CHARDEV=y
CONFIG_NVRAM=y
CONFIG_GEN_RTC=y
CONFIG_EXT2_FS=y
CONFIG_ISO9660_FS=y
CONFIG_JOLIET=y
CONFIG_ZISOFS=y
CONFIG_ZISOFS_FS=y
CONFIG_PROC_FS=y
CONFIG_DEVPTS_FS=y
CONFIG_TMPFS=y
CONFIG_RAMFS=y
CONFIG_NFS_FS=y
CONFIG_NFS_V3=y
CONFIG_LOCKD=y
CONFIG_LOCKD_V4=y
CONFIG_SUNRPC=y
CONFIG_PARTITION_ADVANCED=y
CONFIG_MAC_PARTITION=y
CONFIG_MSDOS_PARTITION=y
CONFIG_NLS=y
CONFIG_NLS_DEFAULT="iso8859-1"
CONFIG_SOUND=y
CONFIG_ZLIB_INFLATE=y
CONFIG_DEBUG_KERNEL=y
CONFIG_MAGIC_SYSRQ=y
CONFIG_KALLSYMS=y
CONFIG_XMON=y
--
USB is for mice, FireWire is for men!
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: 2.5 and serial console
2003-05-05 17:45 ` Olaf Hering
@ 2003-05-05 19:29 ` Tom Rini
2003-05-05 19:44 ` Olaf Hering
0 siblings, 1 reply; 9+ messages in thread
From: Tom Rini @ 2003-05-05 19:29 UTC (permalink / raw)
To: Olaf Hering; +Cc: linuxppc-dev
On Mon, May 05, 2003 at 07:45:44PM +0200, Olaf Hering wrote:
> On Mon, May 05, Tom Rini wrote:
>
> > On Sun, May 04, 2003 at 06:51:16PM +0200, Olaf Hering wrote:
> >
> > > Morning,
> > >
> > > is there a fix for this? It seems to involve Makefile tweaking, at least.
> >
> > What .config file?
>
> It seems CONFIG_SERIAL_8250_CONSOLE is gone. I can not activate it
> anywhere.
You don't ahve CONFIG_SERIAL_8250 selected either. But you do have
CONFIG_SERIAL_CONSOLE enabled. So the question is then, (a) why do you
have that set (pmac serial console?) and (b) why don't you have
CONFIG_SERIAL_8250 set?
--
Tom Rini
http://gate.crashing.org/~trini/
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: 2.5 and serial console
2003-05-05 19:29 ` Tom Rini
@ 2003-05-05 19:44 ` Olaf Hering
2003-05-07 20:20 ` Tom Rini
0 siblings, 1 reply; 9+ messages in thread
From: Olaf Hering @ 2003-05-05 19:44 UTC (permalink / raw)
To: Tom Rini; +Cc: linuxppc-dev
On Mon, May 05, Tom Rini wrote:
> On Mon, May 05, 2003 at 07:45:44PM +0200, Olaf Hering wrote:
> > On Mon, May 05, Tom Rini wrote:
> >
> > > On Sun, May 04, 2003 at 06:51:16PM +0200, Olaf Hering wrote:
> > >
> > > > Morning,
> > > >
> > > > is there a fix for this? It seems to involve Makefile tweaking, at least.
> > >
> > > What .config file?
> >
> > It seems CONFIG_SERIAL_8250_CONSOLE is gone. I can not activate it
> > anywhere.
>
> You don't ahve CONFIG_SERIAL_8250 selected either. But you do have
> CONFIG_SERIAL_CONSOLE enabled. So the question is then, (a) why do you
> have that set (pmac serial console?) and (b) why don't you have
> CONFIG_SERIAL_8250 set?
I had serial console set. Maybe I screwed my config while hunting for a
workaround.
[*] Support for PowerMac serial ports
[*] Support for console on serial port
Well, I bet such a zImage links in 2.4.
I just enabled the PC part and now I have CONFIG_SERIAL_8250.
grepping for CONFIG_FOO doesnt work anymore, you must grep for FOO now.
fun...
Gruss Olaf
--
USB is for mice, FireWire is for men!
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: 2.5 and serial console
2003-05-05 19:44 ` Olaf Hering
@ 2003-05-07 20:20 ` Tom Rini
2003-08-15 21:48 ` Olaf Hering
0 siblings, 1 reply; 9+ messages in thread
From: Tom Rini @ 2003-05-07 20:20 UTC (permalink / raw)
To: Olaf Hering; +Cc: linuxppc-dev
On Mon, May 05, 2003 at 09:44:10PM +0200, Olaf Hering wrote:
> On Mon, May 05, Tom Rini wrote:
>
> > On Mon, May 05, 2003 at 07:45:44PM +0200, Olaf Hering wrote:
> > > On Mon, May 05, Tom Rini wrote:
> > >
> > > > On Sun, May 04, 2003 at 06:51:16PM +0200, Olaf Hering wrote:
> > > >
> > > > > Morning,
> > > > >
> > > > > is there a fix for this? It seems to involve Makefile tweaking, at least.
> > > >
> > > > What .config file?
> > >
> > > It seems CONFIG_SERIAL_8250_CONSOLE is gone. I can not activate it
> > > anywhere.
> >
> > You don't ahve CONFIG_SERIAL_8250 selected either. But you do have
> > CONFIG_SERIAL_CONSOLE enabled. So the question is then, (a) why do you
> > have that set (pmac serial console?) and (b) why don't you have
> > CONFIG_SERIAL_8250 set?
>
> I had serial console set. Maybe I screwed my config while hunting for a
> workaround.
> [*] Support for PowerMac serial ports
> [*] Support for console on serial port
Well that explains it then. The pmac code is bad and still uses
CONFIG_SERIAL_CONSOLE. It needs to be changed, at a miniumum to
CONFIG_SERIAL_PMAC_CONSOLE, and the driver really should be ported to
the new serial backend.
> Well, I bet such a zImage links in 2.4.
That's tangental. But I do need to move the weak symbol code from 2.4
into 2.5 (*sigh*, I thought I did that already).
--
Tom Rini
http://gate.crashing.org/~trini/
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: 2.5 and serial console
2003-05-07 20:20 ` Tom Rini
@ 2003-08-15 21:48 ` Olaf Hering
2003-08-15 23:46 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 9+ messages in thread
From: Olaf Hering @ 2003-08-15 21:48 UTC (permalink / raw)
To: Tom Rini; +Cc: linuxppc-dev
On Wed, May 07, Tom Rini wrote:
> > I had serial console set. Maybe I screwed my config while hunting for a
> > workaround.
> > [*] Support for PowerMac serial ports
> > [*] Support for console on serial port
>
> Well that explains it then. The pmac code is bad and still uses
> CONFIG_SERIAL_CONSOLE. It needs to be changed, at a miniumum to
> CONFIG_SERIAL_PMAC_CONSOLE, and the driver really should be ported to
> the new serial backend.
I'm not the one who can port the driver, but this patch makes it useable
for me.
diff -purNX /home/olaf/kernel/kernel_exclude.txt linuxppc-2.5/arch/ppc/Kconfig linux-2.6.0-test3-lxppc25/arch/ppc/Kconfig
--- linuxppc-2.5/arch/ppc/Kconfig 2003-08-05 01:18:06.000000000 +0200
+++ linux-2.6.0-test3-lxppc25/arch/ppc/Kconfig 2003-08-15 22:25:33.000000000 +0200
@@ -1293,7 +1293,7 @@ config MAC_SERIAL
here. If you also have regular serial ports and enable the driver
for them, you can't currently use the serial console feature.
-config SERIAL_CONSOLE
+config SERIAL_PMAC_CONSOLE
bool "Support for console on serial port"
depends on PPC_PMAC && MAC_SERIAL=y
diff -purNX /home/olaf/kernel/kernel_exclude.txt linuxppc-2.5/drivers/macintosh/macserial.c linux-2.6.0-test3-lxppc25/drivers/macintosh/macserial.c
--- linuxppc-2.5/drivers/macintosh/macserial.c 2003-07-09 05:24:42.000000000 +0200
+++ linux-2.6.0-test3-lxppc25/drivers/macintosh/macserial.c 2003-08-15 22:26:57.000000000 +0200
@@ -28,7 +28,7 @@
#include <linux/kernel.h>
#include <linux/delay.h>
#include <linux/init.h>
-#ifdef CONFIG_SERIAL_CONSOLE
+#ifdef CONFIG_SERIAL_PMAC_CONSOLE
#include <linux/console.h>
#endif
#include <linux/slab.h>
@@ -88,7 +88,7 @@ struct tty_struct zs_ttys[NUM_CHANNELS];
static int is_powerbook;
-#ifdef CONFIG_SERIAL_CONSOLE
+#ifdef CONFIG_SERIAL_PMAC_CONSOLE
static struct console sercons;
#endif
@@ -2230,7 +2230,7 @@ static int rs_open(struct tty_struct *tt
return retval;
}
-#ifdef CONFIG_SERIAL_CONSOLE
+#ifdef CONFIG_SERIAL_PMAC_CONSOLE
if (sercons.cflag && sercons.index == line) {
tty->termios->c_cflag = sercons.cflag;
sercons.cflag = 0;
@@ -2706,7 +2706,7 @@ void unregister_serial(int line)
* Serial console driver
* ------------------------------------------------------------
*/
-#ifdef CONFIG_SERIAL_CONSOLE
+#ifdef CONFIG_SERIAL_PMAC_CONSOLE
/*
* Print a string to the serial port trying not to disturb
@@ -2950,7 +2950,7 @@ static void __init mac_scc_console_init(
}
console_initcall(mac_scc_console_init);
-#endif /* ifdef CONFIG_SERIAL_CONSOLE */
+#endif /* ifdef CONFIG_SERIAL_PMAC_CONSOLE */
#ifdef CONFIG_KGDB
/* These are for receiving and sending characters under the kgdb
--
USB is for mice, FireWire is for men!
sUse lINUX ag, nÜRNBERG
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: 2.5 and serial console
2003-08-15 21:48 ` Olaf Hering
@ 2003-08-15 23:46 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 9+ messages in thread
From: Benjamin Herrenschmidt @ 2003-08-15 23:46 UTC (permalink / raw)
To: Olaf Hering; +Cc: Tom Rini, linuxppc-dev
On Fri, 2003-08-15 at 23:48, Olaf Hering wrote:
> On Wed, May 07, Tom Rini wrote:
>
> > > I had serial console set. Maybe I screwed my config while hunting for a
> > > workaround.
> > > [*] Support for PowerMac serial ports
> > > [*] Support for console on serial port
> >
> > Well that explains it then. The pmac code is bad and still uses
> > CONFIG_SERIAL_CONSOLE. It needs to be changed, at a miniumum to
> > CONFIG_SERIAL_PMAC_CONSOLE, and the driver really should be ported to
> > the new serial backend.
>
> I'm not the one who can port the driver, but this patch makes it useable
> for me.
The driver has been ported in my tree, I'll send it to Linus rsn, that
is once Linus has merged some other pending patches and I've had time
to test it on a few more configurations.
Also, my current port enables the serial console a bit late, I want to
fix that as well.
Ben.
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 9+ messages in thread
* 2.5 and serial console
@ 2003-05-04 22:20 Milton D. Miller II
0 siblings, 0 replies; 9+ messages in thread
From: Milton D. Miller II @ 2003-05-04 22:20 UTC (permalink / raw)
To: linuxppc-dev
I Olaf.
I just ran into this myself. Either enable 8250 and 8250 console, don't
build the prep boot loader, or ignore the fact the prep boot loader doesn't
link (and since its after chrp and pmac, that's the one I chose :)
milton
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2003-08-15 23:46 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-05-04 16:51 2.5 and serial console Olaf Hering
2003-05-05 17:25 ` Tom Rini
2003-05-05 17:45 ` Olaf Hering
2003-05-05 19:29 ` Tom Rini
2003-05-05 19:44 ` Olaf Hering
2003-05-07 20:20 ` Tom Rini
2003-08-15 21:48 ` Olaf Hering
2003-08-15 23:46 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2003-05-04 22:20 Milton D. Miller II
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).