linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Mark Rakes <mrakes@vivato.net>
Cc: linuxppc-dev@lists.linuxppc.org
Subject: Re: e1000 patch for linuxppc_2_4_devel
Date: Sun, 18 May 2003 00:39:01 -0400	[thread overview]
Message-ID: <20030518043901.GA11221@nevyn.them.org> (raw)
In-Reply-To: <3048EFC8-87FB-11D7-B0B0-000393DB7C12@vivato.net>


On Fri, May 16, 2003 at 05:04:54PM -0700, Mark Rakes wrote:
>
> this patch fixes e1000 vlan hardware acceleration on ppc.
>
> vlan tags weren't swapped.
>
> thanks!
> -Mark Rakes
>
>
> diff -Nru a/drivers/net/e1000/e1000_main.c
> b/drivers/net/e1000/e1000_main.c
> --- a/drivers/net/e1000/e1000_main.c	Fri May 16 17:00:24 2003
> +++ b/drivers/net/e1000/e1000_main.c	Fri May 16 17:00:24 2003
> @@ -2062,7 +2062,8 @@
>  		skb->protocol = eth_type_trans(skb, netdev);
>  		if(adapter->vlgrp && (rx_desc->status & E1000_RXD_STAT_VP)) {
>  			vlan_hwaccel_rx(skb, adapter->vlgrp,
> -				le16_to_cpu(rx_desc->special &
> E1000_RXD_SPC_VLAN_MASK));
> +				le16_to_cpu(rx_desc->special &
> +					    E1000_RXD_SPC_VLAN_MASK));
>  		} else {
>  			netif_rx(skb);
>  		}

That patch doesn't do anything but move a line break.  Is that really
what you meant to do?

--
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

  reply	other threads:[~2003-05-18  4:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-17  0:04 e1000 patch for linuxppc_2_4_devel Mark Rakes
2003-05-18  4:39 ` Daniel Jacobowitz [this message]
2003-05-19 16:25   ` Mark Rakes
2003-05-19 15:21 ` linas
2003-05-20 19:07 ` Mark Rakes
2003-05-21 22:10   ` Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030518043901.GA11221@nevyn.them.org \
    --to=drow@false.org \
    --cc=linuxppc-dev@lists.linuxppc.org \
    --cc=mrakes@vivato.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).