[PATCH] consistent_sync unaligned buffers debug check, resend

[PATCH] consistent_sync unaligned buffers debug check, resend

[Eugene Surovegin]

Hi!

I suspect original e-mail had bad timing, all important people were busy
preparing/flying to OLS ;-)
So, here is another try...

These patches add new debugging option under "Kernel hacking|Kernel debugging".
This option enables rate-limited warning print out when consistent_sync is
called with unaligned buffer.

Patch against 2.4:
http://kernel.ebshome.net/consistent_sync_debug-2.4.diff

Patch against 2.6
http://kernel.ebshome.net/consistent_sync_debug-2.6.diff

Comments/suggestions :)

Eugene.


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

Re: [PATCH] consistent_sync unaligned buffers debug check, resend

[Matt Porter]

On Mon, Aug 04, 2003 at 09:40:02PM -0700, Eugene Surovegin wrote:
> I suspect original e-mail had bad timing, all important people were busy
> preparing/flying to OLS ;-)

Heh

> So, here is another try...
>
> These patches add new debugging option under "Kernel hacking|Kernel debugging".
> This option enables rate-limited warning print out when consistent_sync is
> called with unaligned buffer.

Looks fine to me.  I'll add it to my large queue of changesets for
Paul to review/pull to marcelo's tree.

FWIW, I talked to a bunch of SCSI folks at OLS about DMA off the stack
and they believe it's all gone in 2.6.  I double-checked and that does
seem to be the case.  Nevertheless, I think we will always be fighting
poorly written drivers so this seems to be a great debug option.

Regards,
--
Matt Porter
mporter@kernel.crashing.org

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/