linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* question about UART ST16C2552
@ 2003-09-18  1:37 Yuxiao Xi
  2003-09-18 16:00 ` Kumar Gala
  0 siblings, 1 reply; 6+ messages in thread
From: Yuxiao Xi @ 2003-09-18  1:37 UTC (permalink / raw)
  To: linuxppc-embedded


Hi,all,
    Does Linux support UART ST16C2552 ?
    There is a UART ST16C2552 on my board with CPU ppc8240.
While the linux system booting,sometimes function autoconfig(struct
serial_state * state) in ./drivers/char/serial.c detected ST16C2552 as
16450,sometimes as 8250,can anyone tell me why?

¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡Yuxiao Xi
¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡xiyuxiao@harbournetworks.com
¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡2003-09-18

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: question about UART ST16C2552
  2003-09-18  1:37 Yuxiao Xi
@ 2003-09-18 16:00 ` Kumar Gala
  0 siblings, 0 replies; 6+ messages in thread
From: Kumar Gala @ 2003-09-18 16:00 UTC (permalink / raw)
  To: Yuxiao Xi; +Cc: linuxppc-embedded


For 824x the detection code for the on-chip UART does NOT currently
detect it as a 16550A.  There is a patch that Tom Rini and I are
working on getting accepted by the serial maintainers, that should fix
this.

However, its not clear to me from your email if you also have a
ST16C2552 in addition to the DUART on the 8240.

- kumar

On Wednesday, September 17, 2003, at 08:37 PM, Yuxiao Xi wrote:

>
> Hi,all,
>     Does Linux support UART ST16C2552 ?
>     There is a UART ST16C2552 on my board with CPU ppc8240.
> While the linux system booting,sometimes function autoconfig(struct
> serial_state * state) in ./drivers/char/serial.c detected ST16C2552 as
> 16450,sometimes as 8250,can anyone tell me why?
>
> !!!!!!!!!!!!!!!!Yuxiao Xi
> !!!!!!!!!!!!!!!!xiyuxiao@harbournetworks.com
> !!!!!!!!!!!!!!!!!!!!2003-09-18
>


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: question about UART ST16C2552
@ 2003-09-18 16:23 Milliorn Gary-rxcr80
  2003-09-18 16:29 ` Kumar Gala
  0 siblings, 1 reply; 6+ messages in thread
From: Milliorn Gary-rxcr80 @ 2003-09-18 16:23 UTC (permalink / raw)
  To: Gala Kumar K.-galak, Yuxiao Xi; +Cc: linuxppc-embedded

[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]

Kumar,

  There is no DUART on the MPC8240, if 8240 is what he literally
meant.  Some boards, like Unity, used to have an external DUART
for this reason.

Gary Milliorn



> -----Original Message-----
> From: Kumar Gala [mailto:kumar.gala@motorola.com]
> Sent: Thursday, September 18, 2003 11:01 AM
> To: Yuxiao Xi
> Cc: linuxppc-embedded
> Subject: Re: question about UART ST16C2552
>
>
>
> For 824x the detection code for the on-chip UART does NOT currently
> detect it as a 16550A.  There is a patch that Tom Rini and I are
> working on getting accepted by the serial maintainers, that should fix
> this.
>
> However, its not clear to me from your email if you also have a
> ST16C2552 in addition to the DUART on the 8240.
>
> - kumar
>
> On Wednesday, September 17, 2003, at 08:37 PM, Yuxiao Xi wrote:
>
> >
> > Hi,all,
> >     Does Linux support UART ST16C2552 ?
> >     There is a UART ST16C2552 on my board with CPU ppc8240.
> > While the linux system booting,sometimes function autoconfig(struct
> > serial_state * state) in ./drivers/char/serial.c detected
> ST16C2552 as
> > 16450,sometimes as 8250,can anyone tell me why?
> >
> > !!!!!!!!!!!!!!!!Yuxiao Xi
> > !!!!!!!!!!!!!!!!xiyuxiao@harbournetworks.com
> > !!!!!!!!!!!!!!!!!!!!2003-09-18
> >
>
>
>


[-- Attachment #2: Gary Milliorn (E-mail).vcf --]
[-- Type: application/octet-stream, Size: 457 bytes --]

BEGIN:VCARD
VERSION:2.1
N:Milliorn;Gary
FN:Milliorn Gary-rxcr80
ORG:10060985;SD646
TEL;WORK;VOICE:5129667066
ADR;WORK;ENCODING=QUOTED-PRINTABLE:;TX32/PL44;MOTOROLA INC.=0D=0A7700 W. PARMER LANE;AUSTIN;TEXAS;78729;UNITED =
STATES
LABEL;WORK;ENCODING=QUOTED-PRINTABLE:TX32/PL44=0D=0AMOTOROLA INC.=0D=0A7700 W. PARMER LANE=0D=0AAUSTIN, TEXAS 787=
29=0D=0AUNITED STATES
EMAIL;PREF;INTERNET:Gary.Milliorn@motorola.com
REV:20021104T215429Z
END:VCARD

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: question about UART ST16C2552
  2003-09-18 16:23 Milliorn Gary-rxcr80
@ 2003-09-18 16:29 ` Kumar Gala
  0 siblings, 0 replies; 6+ messages in thread
From: Kumar Gala @ 2003-09-18 16:29 UTC (permalink / raw)
  To: Milliorn Gary-rxcr80; +Cc: Yuxiao Xi, linuxppc-embedded


Thanks for the correction.  I guess my comments really apply to 8241,
8245 and 8540 then.

- kumar

On Thursday, September 18, 2003, at 11:23 AM, Milliorn Gary-rxcr80
wrote:

> Kumar,
>
>   There is no DUART on the MPC8240, if 8240 is what he literally
> meant.  Some boards, like Unity, used to have an external DUART
> for this reason.
>
> Gary Milliorn
>
>
>
> > -----Original Message-----
> > From: Kumar Gala [mailto:kumar.gala@motorola.com]
> > Sent: Thursday, September 18, 2003 11:01 AM
> > To: Yuxiao Xi
> > Cc: linuxppc-embedded
> > Subject: Re: question about UART ST16C2552
> >
> >
> >
> > For 824x the detection code for the on-chip UART does NOT currently
> > detect it as a 16550A.  There is a patch that Tom Rini and I are
> > working on getting accepted by the serial maintainers, that should
> fix
> > this.
> >
> > However, its not clear to me from your email if you also have a
> > ST16C2552 in addition to the DUART on the 8240.
> >
> > - kumar
> >
> > On Wednesday, September 17, 2003, at 08:37 PM, Yuxiao Xi wrote:
> >
> > >
> > > Hi,all,
> > >     Does Linux support UART ST16C2552 ?
> > >     There is a UART ST16C2552 on my board with CPU ppc8240.
> > > While the linux system booting,sometimes function autoconfig(struct
> > > serial_state * state) in ./drivers/char/serial.c detected
> > ST16C2552 as
> > > 16450,sometimes as 8250,can anyone tell me why?
> > >
> > > !!!!!!!!!!!!!!!!Yuxiao Xi
> > > !!!!!!!!!!!!!!!!xiyuxiao@harbournetworks.com
> > > !!!!!!!!!!!!!!!!!!!!2003-09-18
> > >
> >
> >
> >
>
>  
>
> <Gary Milliorn (E-mail).vcf>

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: question about UART ST16C2552
@ 2003-09-19  1:39 Yuxiao Xi
  0 siblings, 0 replies; 6+ messages in thread
From: Yuxiao Xi @ 2003-09-19  1:39 UTC (permalink / raw)
  To: Kumar Gala; +Cc: linuxppc-embedded@lists.linuxppc.org


Yes,I have an external DUART ST16C2552.
Kumar,should ST16C2552 be detected as 16550A?
When and where can I get the patch for the on-chip UART you said?
Thanks.

> -----Original Message-----
> From: Kumar Gala [mailto:kumar.gala@motorola.com]
>Thanks for the correction.  I guess my comments really apply to 8241,
>8245 and 8540 then.
>
>On Thursday, September 18, 2003, at 11:23 AM, Milliorn Gary-rxcr80 wrote:
>
>>  There is no DUART on the MPC8240, if 8240 is what he literally
>> meant. Some boards, like Unity, used to have an external DUART
>> for this reason.
>>
>> > -----Original Message-----
>> > From: Kumar Gala [mailto:kumar.gala@motorola.com]
>> > Sent: Thursday, September 18, 2003 11:01 AM
>> > Subject: Re: question about UART ST16C2552
>> >
>> > For 824x the detection code for the on-chip UART does NOT currently
>> > detect it as a 16550A.  There is a patch that Tom Rini and I are
>> > working on getting accepted by the serial maintainers, that should
>> > fix this.
>> >
>> > However, its not clear to me from your email if you also have a
>> > ST16C2552 in addition to the DUART on the 8240.

¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡Yuxiao Xi
¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡xiyuxiao@harbournetworks.com
¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡2003-09-19

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: question about UART ST16C2552
       [not found] <200309190129.h8J1TcaJ006055@motgate5.mot.com>
@ 2003-09-19  6:24 ` Kumar Gala
  0 siblings, 0 replies; 6+ messages in thread
From: Kumar Gala @ 2003-09-19  6:24 UTC (permalink / raw)
  To: Yuxiao Xi; +Cc: linuxppc-embedded


Acutally, I misunderstood your question.  The patch I've listed below
is to make the DUART on 8241/8245/8540 be detected correctly as a
16550A.  The current code detects it as a startech uart.


diff -u -3 -t -p -r1.1.1.1 serial.c
--- serial.c    2003/09/05 22:29:42     1.1.1.1
+++ serial.c    2003/09/19 06:22:09
@@ -3741,13 +3741,17 @@ static void autoconfig(struct serial_sta
                  /* Check for Startech UART's */
                  serial_outp(info, UART_LCR, UART_LCR_DLAB);
                  if (serial_in(info, UART_EFR) == 0) {
-                        state->type = PORT_16650;
+                        serial_outp(info, UART_EFR, 0xA8);
+                        if (serial_in(info, UART_EFR) != 0)
+                                state->type = PORT_16650;
+                        serial_outp(info, UART_EFR, 0);
                  } else {
                          serial_outp(info, UART_LCR, 0xBF);
                          if (serial_in(info, UART_EFR) == 0)
                                  autoconfig_startech_uarts(info, state,
flags);
                  }
          }

- kumar

On Thursday, September 18, 2003, at 08:39 PM, Yuxiao Xi wrote:

> Yes,I have an external DUART ST16C2552.
> Kumar,should ST16C2552 be detected as 16550A?
> When and where can I get the patch for the on-chip UART you said?
> Thanks.
>
>
>
>
>
>> Thanks for the correction.  I guess my comments really apply to 8241,
>> 8245 and 8540 then.
>>
>> - kumar
>>
>> On Thursday, September 18, 2003, at 11:23 AM, Milliorn Gary-rxcr80
>> wrote:
>>
>>> Kumar,
>>>
>>>   There is no DUART on the MPC8240, if 8240 is what he literally
>>> meant.  Some boards, like Unity, used to have an external DUART
>>> for this reason.
>>>
>>> Gary Milliorn
>>>
>>>
>>>
>>>> -----Original Message-----
>>>> From: Kumar Gala [mailto:kumar.gala@motorola.com]
>>>> Sent: Thursday, September 18, 2003 11:01 AM
>>>> To: Yuxiao Xi
>>>> Cc: linuxppc-embedded
>>>> Subject: Re: question about UART ST16C2552
>>>>
>>>>
>>>>
>>>> For 824x the detection code for the on-chip UART does NOT currently
>>>> detect it as a 16550A.  There is a patch that Tom Rini and I are
>>>> working on getting accepted by the serial maintainers, that should
>>> fix
>>>> this.
>>>>
>>>> However, its not clear to me from your email if you also have a
>>>> ST16C2552 in addition to the DUART on the 8240.
>>>>
>>>> - kumar
>>>>
>
>
>
> ¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡Yuxiao Xi
> ¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡xiyuxiao@harbournetworks.com
> ¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡2003-09-19


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2003-09-19  6:24 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-09-19  1:39 question about UART ST16C2552 Yuxiao Xi
     [not found] <200309190129.h8J1TcaJ006055@motgate5.mot.com>
2003-09-19  6:24 ` Kumar Gala
  -- strict thread matches above, loose matches on Subject: below --
2003-09-18 16:23 Milliorn Gary-rxcr80
2003-09-18 16:29 ` Kumar Gala
2003-09-18  1:37 Yuxiao Xi
2003-09-18 16:00 ` Kumar Gala

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).