* [PATCH] incorrect function declaration for claim()
@ 2003-11-06 20:24 Olaf Hering
2003-11-06 22:31 ` Sam Ravnborg
0 siblings, 1 reply; 2+ messages in thread
From: Olaf Hering @ 2003-11-06 20:24 UTC (permalink / raw)
To: linuxppc-dev
its void * in start.c
--- linux-2.4/arch/ppc/boot/chrp/main.c~ 2003-07-17 19:28:11.000000000 +0200
+++ linux-2.4/arch/ppc/boot/chrp/main.c 2003-11-06 21:21:26.000000000 +0100
@@ -17,7 +17,7 @@ extern char _start, _end;
extern int getprop(void *, const char *, void *, int);
extern unsigned int heap_max;
-extern void claim(unsigned int virt, unsigned int size, unsigned int align);
+extern void *claim(unsigned int virt, unsigned int size, unsigned int align);
extern void *finddevice(const char *);
extern void flush_cache(void *, unsigned long);
extern void gunzip(void *, int, unsigned char *, int *);
--
USB is for mice, FireWire is for men!
sUse lINUX ag, nÜRNBERG
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] incorrect function declaration for claim()
2003-11-06 20:24 [PATCH] incorrect function declaration for claim() Olaf Hering
@ 2003-11-06 22:31 ` Sam Ravnborg
0 siblings, 0 replies; 2+ messages in thread
From: Sam Ravnborg @ 2003-11-06 22:31 UTC (permalink / raw)
To: Olaf Hering; +Cc: linuxppc-dev
On Thu, Nov 06, 2003 at 09:24:45PM +0100, Olaf Hering wrote:
> +++ linux-2.4/arch/ppc/boot/chrp/main.c 2003-11-06 21:21:26.000000000 +0100
> @@ -17,7 +17,7 @@ extern char _start, _end;
>
> extern int getprop(void *, const char *, void *, int);
> extern unsigned int heap_max;
> -extern void claim(unsigned int virt, unsigned int size, unsigned int align);
> +extern void *claim(unsigned int virt, unsigned int size, unsigned int align);
> extern void *finddevice(const char *);
> extern void flush_cache(void *, unsigned long);
> extern void gunzip(void *, int, unsigned char *, int *);
In general I consider it a bug to have prototypes in a .c file....
Sam
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-11-06 22:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-11-06 20:24 [PATCH] incorrect function declaration for claim() Olaf Hering
2003-11-06 22:31 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).