From: Tom Rini <trini@kernel.crashing.org>
To: Anton Blanchard <anton@samba.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Linux/PPC Development <linuxppc-dev@lists.linuxppc.org>
Subject: Re: PPC32: Add support for the OpenPIC register set to be in BE mode.
Date: Mon, 5 Jan 2004 08:41:08 -0700 [thread overview]
Message-ID: <20040105154108.GA2415@stop.crashing.org> (raw)
In-Reply-To: <20040105152830.GJ12213@krispykreme>
On Tue, Jan 06, 2004 at 02:28:30AM +1100, Anton Blanchard wrote:
> > > diff -Nru a/arch/ppc/kernel/open_pic.c b/arch/ppc/kernel/open_pic.c
> > > --- a/arch/ppc/kernel/open_pic.c Sat Jan 3 12:02:04 2004
> > > +++ b/arch/ppc/kernel/open_pic.c Sat Jan 3 12:02:04 2004
> > > @@ -166,13 +166,21 @@
> > > {
> > > u_int val;
> > >
> > > +#ifdef CONFIG_PPC_OPENPIC_BE
> > > + val = in_be32(addr);
> > > +#else
> > > val = in_le32(addr);
> > > +#endif
> > > return val;
> > > }
> >
> > Wouldn't it be better to #define openpic_in() and openpic_out() macros, so you
> > need the #ifdef at one spot only?
I suppose we should do it like that for 2.6 (note made).
> Or grab the bit out of the ppc64 openpic code that detects this at runtime
> and get rid of the CONFIG option completely :)
I assume you mean the broken_ipi_registers bit (I only see used in one
spot in what I've got locall) ? I think maybe with some thought it could
work (it's needed in openpic_{read,write} as well for these machines,
prpmc800 and e500, iirc).
--
Tom Rini
http://gate.crashing.org/~trini/
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
prev parent reply other threads:[~2004-01-05 15:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200401032002.i03K23iM024298@hera.kernel.org>
2004-01-05 14:02 ` PPC32: Add support for the OpenPIC register set to be in BE mode Geert Uytterhoeven
2004-01-05 15:28 ` Anton Blanchard
2004-01-05 15:41 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040105154108.GA2415@stop.crashing.org \
--to=trini@kernel.crashing.org \
--cc=anton@samba.org \
--cc=geert@linux-m68k.org \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).