From: Anton Blanchard <anton@samba.org>
To: Peter Bergner <bergner@vnet.ibm.com>
Cc: Franz Sirl <Franz.Sirl-ppc@lauterbach.com>,
joakim.tjernlund@lumentis.se, linuxppc-dev@lists.linuxppc.org
Subject: Re: TASK_UNMAPPED_BASE
Date: Thu, 5 Feb 2004 01:47:07 +1100 [thread overview]
Message-ID: <20040204144707.GK19011@krispykreme> (raw)
In-Reply-To: <1075905440.2895.23.camel@otta.rchland.ibm.com>
> I've seen problems with HPC apps/benchmarks with huge bss's that fail to
> run because TASK_UNMAPED_BASE is set too low. I'll admit they fail to
> run due to a bug in the fs/binfmt_elf.c, but the fix has never been
> accepted yet. The bug is that we don't reserve the bss region for the
> app (via a set_brk/do_brk call) until after we've loaded the loader so
> they get mapped to overlapping memory locations. The fix is to move the
> update to current->mm.* and the set_brk/do_brk call to before the point
> we call load_elf_interp().
>
> Another bug is that the calls to set_brk/do_brk in fs/binfmt_elf.c fail to
> check whether the set_brk/do_brk calls succeeded or not, so they implicitly
> assume they do. With an app with a huge bss, the set_brk/do_brk call actually
> returns -ENOMEM which is then ignored. The fix is to test for failure from
> the set_brk/do_brk calls.
A patch went into 2.6 that should fix both of these problems. Give all
those nasty test cases another run :)
Anton
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2004-02-04 14:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-03 13:05 TASK_UNMAPPED_BASE Joakim Tjernlund
2004-02-03 15:22 ` TASK_UNMAPPED_BASE Franz Sirl
2004-02-03 16:51 ` TASK_UNMAPPED_BASE Joakim Tjernlund
2004-02-04 14:37 ` TASK_UNMAPPED_BASE Peter Bergner
2004-02-04 14:47 ` Anton Blanchard [this message]
2004-02-04 21:58 ` TASK_UNMAPPED_BASE Peter Bergner
2004-02-05 8:57 ` TASK_UNMAPPED_BASE Joakim Tjernlund
2004-02-05 16:34 ` TASK_UNMAPPED_BASE Peter Bergner
2004-02-05 17:06 ` TASK_UNMAPPED_BASE Anton Blanchard
2004-02-06 10:53 ` TASK_UNMAPPED_BASE Joakim Tjernlund
2004-02-05 17:10 ` TASK_UNMAPPED_BASE Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040204144707.GK19011@krispykreme \
--to=anton@samba.org \
--cc=Franz.Sirl-ppc@lauterbach.com \
--cc=bergner@vnet.ibm.com \
--cc=joakim.tjernlund@lumentis.se \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).