From: Tom Rini <trini@kernel.crashing.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: "debian-powerpc@lists.debian.org"
<debian-powerpc@lists.debian.org>,
linuxppc-dev list <linuxppc-dev@lists.linuxppc.org>
Subject: Re: Need testers: G3 @ G4 laptops (powerbooks & ibooks)
Date: Tue, 24 Feb 2004 10:54:09 -0700 [thread overview]
Message-ID: <20040224175409.GC1052@smtp.west.cox.net> (raw)
In-Reply-To: <1077074495.1082.94.camel@gaston>
On Wed, Feb 18, 2004 at 02:21:36PM +1100, Benjamin Herrenschmidt wrote:
>
> Hi need people who own those machiens, especially the recent iBook2 models
> with a G3 CPU and titanium powerbooks with a G4, to test this patch and
> tell me if sleep mode still works reliably or becomes unstable.
[snip]
> ===== arch/ppc/kernel/l2cr.S 1.15 vs edited =====
> --- 1.15/arch/ppc/kernel/l2cr.S Tue Oct 14 17:28:01 2003
> +++ edited/arch/ppc/kernel/l2cr.S Wed Feb 18 14:14:33 2004
> @@ -130,11 +130,13 @@
> mtspr HID0,r4 /* Disable DPM */
> sync
>
> +#if 0
> /* Flush & disable L1 */
> mr r5,r3
> bl __flush_disable_L1
> mr r3,r5
> -
> +#endif
> +
> /* Get the current enable bit of the L2CR into r4 */
> mfspr r4,L2CR
>
> @@ -236,8 +238,10 @@
> sync
>
> 4:
> - bl __inval_enable_L1
>
> +#if 0
> + bl __inval_enable_L1
> +#endif
> /* Restore HID0[DPM] to whatever it was before */
> sync
> mtspr 1008,r8
Are you sure that you can get away with this, passed on how the manuals
(745x) describe the sequence of flush/invalidating the L2 (and, L3) ?
--
Tom Rini
http://gate.crashing.org/~trini/
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2004-02-24 17:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-18 3:21 Need testers: G3 @ G4 laptops (powerbooks & ibooks) Benjamin Herrenschmidt
2004-02-18 15:45 ` Kiko Piris
2004-02-18 22:30 ` Benjamin Herrenschmidt
2004-02-18 16:03 ` digger vermont
2004-02-18 16:09 ` Colin Leroy
2004-02-18 16:31 ` digger vermont
2004-02-18 22:31 ` Benjamin Herrenschmidt
2004-02-18 17:45 ` Greg Watson
2004-02-18 17:58 ` digger vermont
2004-02-18 18:04 ` Michael Schmitz
2004-02-18 22:14 ` Ira Weiny
2004-02-24 17:54 ` Tom Rini [this message]
2004-02-24 22:39 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2004-02-25 21:46 Mark A. Greer
2004-02-25 23:47 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040224175409.GC1052@smtp.west.cox.net \
--to=trini@kernel.crashing.org \
--cc=benh@kernel.crashing.org \
--cc=debian-powerpc@lists.debian.org \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).