From: Tom Rini <trini@kernel.crashing.org>
To: Leigh Brown <leigh@solinno.co.uk>
Cc: Andrew Morton <akpm@osdl.org>, linuxppc-dev@lists.linuxppc.org
Subject: Re: Please revert "use todc time functions for PPC_PREP" changeset
Date: Sat, 28 Feb 2004 08:33:59 -0700 [thread overview]
Message-ID: <20040228153359.GP1052@smtp.west.cox.net> (raw)
In-Reply-To: <1275.80.7.99.14.1077957786.squirrel@www.solinno.co.uk>
On Sat, Feb 28, 2004 at 08:43:06AM -0000, Leigh Brown wrote:
> Andrew Morton said:
> >
> > "Leigh Brown" <leigh@solinno.co.uk> wrote:
> >>
> >> Hi Tom,
> >>
> >> Your patch (ChangeSet@1.1557.41.25) breaks the 43p140 and Carolina, and
> >> probably quite a few other RS/6000 based PRePs. I was a bit surprised
> >> to see it 2.6.3.
> >>
> >> http://linux.bkbits.net:8080/linux-2.5/patch@1.1557.41.25?nav=index.html|ChangeSet@-3w|cset@1.1557.41.25
> >>
> >> Can we revert this until there is a working version, please?
> >
> > It wouild help if you could define "breaks".
>
> Sorry! It hangs during boot, before any output on the serial console. I
> got as far as working out that it hangs somewhere in
> arch/ppc/kernel/time.c:time_init() (or one of the called functions).
Er.. Didn't we talk about this awhile ago, and get a different version
of this patch working back in 2.4? The problem was that we couldn't use
todc_calibrate_decr we had to still grab the value from the residual
data. And I thought I had kept that logic still..
--
Tom Rini
http://gate.crashing.org/~trini/
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2004-02-28 15:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-28 8:23 Please revert "use todc time functions for PPC_PREP" changeset Leigh Brown
2004-02-28 8:32 ` Andrew Morton
2004-02-28 8:28 ` Benjamin Herrenschmidt
2004-02-28 8:45 ` Leigh Brown
2004-02-28 8:43 ` Leigh Brown
2004-02-28 15:33 ` Tom Rini [this message]
2004-03-05 8:19 ` Leigh Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040228153359.GP1052@smtp.west.cox.net \
--to=trini@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=leigh@solinno.co.uk \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).