From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Sat, 28 Feb 2004 08:33:59 -0700 From: Tom Rini To: Leigh Brown Cc: Andrew Morton , linuxppc-dev@lists.linuxppc.org Subject: Re: Please revert "use todc time functions for PPC_PREP" changeset Message-ID: <20040228153359.GP1052@smtp.west.cox.net> References: <1180.80.7.99.14.1077956583.squirrel@www.solinno.co.uk> <20040228003259.3dd5c25a.akpm@osdl.org> <1275.80.7.99.14.1077957786.squirrel@www.solinno.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1275.80.7.99.14.1077957786.squirrel@www.solinno.co.uk> Sender: owner-linuxppc-dev@lists.linuxppc.org List-Id: On Sat, Feb 28, 2004 at 08:43:06AM -0000, Leigh Brown wrote: > Andrew Morton said: > > > > "Leigh Brown" wrote: > >> > >> Hi Tom, > >> > >> Your patch (ChangeSet@1.1557.41.25) breaks the 43p140 and Carolina, and > >> probably quite a few other RS/6000 based PRePs. I was a bit surprised > >> to see it 2.6.3. > >> > >> http://linux.bkbits.net:8080/linux-2.5/patch@1.1557.41.25?nav=index.html|ChangeSet@-3w|cset@1.1557.41.25 > >> > >> Can we revert this until there is a working version, please? > > > > It wouild help if you could define "breaks". > > Sorry! It hangs during boot, before any output on the serial console. I > got as far as working out that it hangs somewhere in > arch/ppc/kernel/time.c:time_init() (or one of the called functions). Er.. Didn't we talk about this awhile ago, and get a different version of this patch working back in 2.4? The problem was that we couldn't use todc_calibrate_decr we had to still grab the value from the residual data. And I thought I had kept that logic still.. -- Tom Rini http://gate.crashing.org/~trini/ ** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/