From: Eugene Surovegin <ebs@ebshome.net>
To: llandre <llandre@wawnet.biz>
Cc: benh@kernel.crashing.org,
Stefan Roese <stefan.roese@esd-electronics.com>,
linuxppc-embedded@lists.linuxppc.org,
Matt Porter <mporter@kernel.crashing.org>
Subject: Re: Bug in new IBM 4xx on-chip Ethernet drivers?
Date: Wed, 3 Mar 2004 10:36:37 -0800 [thread overview]
Message-ID: <20040303183637.GA32732@gate.ebshome.net> (raw)
In-Reply-To: <6.0.1.1.0.20040303103039.01efcac0@dns.struinfo.it>
On Wed, Mar 03, 2004 at 10:48:00AM +0100, llandre wrote:
> I'm working with a custom 405EP-based board. So far I used the kernel 2.4.20
> and now I'm moving to the 2.4.23. I realized that the on-chip Ethernet MAC
> driver
> changed.
> I have a question about the function emac_phy_read in ibm_ocp_enet.c file.
> In my understanding the following snippet is not correct
>
> /* Clear the speed bits and make a read request to the PHY */
> stacr = ((EMAC_STACR_READ | (reg & 0x1f)) & ~EMAC_STACR_CLK_100MHZ);
> stacr |= ((mii_id & 0x1F) << 5);
>
> because it assumes the OPB clock frequency is 50MHz. If it differs,
> the MII clock frequency generated by the Ethernet controller is erroneous.
> For example, with OPB frequency = 66MHz, the MII clock frequency is set
> to 3.3MHz (this should be 2.5MHz).
Although you are rigth that this code needs fixing, my experience with
different 4xx hardware running with different OPB clock speed showed
that even incorrect setting doesn't affect MII operation.
And to be fair, all previous EMAC drivers had the same bug :).
Eugene.
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2004-03-03 18:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-03 9:48 Bug in new IBM 4xx on-chip Ethernet drivers? llandre
2004-03-03 10:57 ` Benjamin Herrenschmidt
2004-03-03 11:59 ` llandre
2004-03-03 18:46 ` Matt Porter
2004-03-03 18:36 ` Eugene Surovegin [this message]
2004-03-08 8:41 ` llandre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040303183637.GA32732@gate.ebshome.net \
--to=ebs@ebshome.net \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-embedded@lists.linuxppc.org \
--cc=llandre@wawnet.biz \
--cc=mporter@kernel.crashing.org \
--cc=stefan.roese@esd-electronics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).