* [PATCH] simple class for adb
@ 2004-05-01 18:26 Olaf Hering
2004-05-01 22:36 ` Benjamin Herrenschmidt
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Olaf Hering @ 2004-05-01 18:26 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Benjamin Herrenschmidt, Greg KH
This adds /sys/class/adb/, removes unused devfs lines and updates a
comment to match reality.
diff -p -purN linux-2.6.6-rc3/drivers/macintosh/adb.c linux-2.6.6-rc3.adb/drivers/macintosh/adb.c
--- linux-2.6.6-rc3/drivers/macintosh/adb.c 2004-04-04 05:38:26.000000000 +0200
+++ linux-2.6.6-rc3.adb/drivers/macintosh/adb.c 2004-05-01 19:58:08.000000000 +0200
@@ -10,7 +10,7 @@
*
* To do:
*
- * - /proc/adb to list the devices and infos
+ * - /sys/bus/adb to list the devices and infos
* - more /dev/adb to allow userland to receive the
* flow of auto-polling datas from a given device.
* - move bus probe to a kernel thread
@@ -23,7 +23,6 @@
#include <linux/slab.h>
#include <linux/module.h>
#include <linux/fs.h>
-#include <linux/devfs_fs_kernel.h>
#include <linux/mm.h>
#include <linux/sched.h>
#include <linux/smp_lock.h>
@@ -36,6 +35,7 @@
#include <linux/delay.h>
#include <linux/spinlock.h>
#include <linux/completion.h>
+#include <linux/device.h>
#include <asm/uaccess.h>
#include <asm/semaphore.h>
#ifdef CONFIG_PPC
@@ -75,6 +75,8 @@ static struct adb_driver *adb_driver_lis
NULL
};
+static struct class_simple *adb_dev_class;
+
struct adb_driver *adb_controller;
struct notifier_block *adb_client_list = NULL;
static int adb_got_sleep;
@@ -883,6 +889,7 @@ out:
}
static struct file_operations adb_fops = {
+ .owner = THIS_MODULE,
.llseek = no_llseek,
.read = adb_read,
.write = adb_write,
@@ -893,9 +900,13 @@ static struct file_operations adb_fops =
static void
adbdev_init(void)
{
- if (register_chrdev(ADB_MAJOR, "adb", &adb_fops))
+ if (register_chrdev(ADB_MAJOR, "adb", &adb_fops)) {
printk(KERN_ERR "adb: unable to get major %d\n", ADB_MAJOR);
- else
- devfs_mk_cdev(MKDEV(ADB_MAJOR, 0),
- S_IFCHR | S_IRUSR | S_IWUSR, "adb");
+ return;
+ }
+ adb_dev_class = class_simple_create(THIS_MODULE, "adb");
+ if (IS_ERR(adb_dev_class)) {
+ return;
+ }
+ class_simple_device_add(adb_dev_class, MKDEV(ADB_MAJOR, 0), NULL, "adb");
}
--
USB is for mice, FireWire is for men!
sUse lINUX ag, nÜRNBERG
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] simple class for adb
2004-05-01 18:26 [PATCH] simple class for adb Olaf Hering
@ 2004-05-01 22:36 ` Benjamin Herrenschmidt
2004-05-02 4:07 ` Brad Boyer
2004-05-02 8:14 ` Geert Uytterhoeven
2004-05-04 20:58 ` Greg KH
2 siblings, 1 reply; 6+ messages in thread
From: Benjamin Herrenschmidt @ 2004-05-01 22:36 UTC (permalink / raw)
To: Olaf Hering; +Cc: linuxppc-dev list, Greg KH
On Sun, 2004-05-02 at 04:26, Olaf Hering wrote:
> This adds /sys/class/adb/, removes unused devfs lines and updates a
> comment to match reality.
I'm not sure I want to keep /dev/adb forever.... This is at best a
workaround so that udev creates it. Ultimately, we want a real adb
bus in the device-model and a different mecanism to send special
commands to the system controller. I think somebody from the m68k
folks is already working on the ADB bus stuff though.
Ben.
>
> diff -p -purN linux-2.6.6-rc3/drivers/macintosh/adb.c linux-2.6.6-rc3.adb/drivers/macintosh/adb.c
> --- linux-2.6.6-rc3/drivers/macintosh/adb.c 2004-04-04 05:38:26.000000000 +0200
> +++ linux-2.6.6-rc3.adb/drivers/macintosh/adb.c 2004-05-01 19:58:08.000000000 +0200
> @@ -10,7 +10,7 @@
> *
> * To do:
> *
> - * - /proc/adb to list the devices and infos
> + * - /sys/bus/adb to list the devices and infos
> * - more /dev/adb to allow userland to receive the
> * flow of auto-polling datas from a given device.
> * - move bus probe to a kernel thread
> @@ -23,7 +23,6 @@
> #include <linux/slab.h>
> #include <linux/module.h>
> #include <linux/fs.h>
> -#include <linux/devfs_fs_kernel.h>
> #include <linux/mm.h>
> #include <linux/sched.h>
> #include <linux/smp_lock.h>
> @@ -36,6 +35,7 @@
> #include <linux/delay.h>
> #include <linux/spinlock.h>
> #include <linux/completion.h>
> +#include <linux/device.h>
> #include <asm/uaccess.h>
> #include <asm/semaphore.h>
> #ifdef CONFIG_PPC
> @@ -75,6 +75,8 @@ static struct adb_driver *adb_driver_lis
> NULL
> };
>
> +static struct class_simple *adb_dev_class;
> +
> struct adb_driver *adb_controller;
> struct notifier_block *adb_client_list = NULL;
> static int adb_got_sleep;
> @@ -883,6 +889,7 @@ out:
> }
>
> static struct file_operations adb_fops = {
> + .owner = THIS_MODULE,
> .llseek = no_llseek,
> .read = adb_read,
> .write = adb_write,
> @@ -893,9 +900,13 @@ static struct file_operations adb_fops =
> static void
> adbdev_init(void)
> {
> - if (register_chrdev(ADB_MAJOR, "adb", &adb_fops))
> + if (register_chrdev(ADB_MAJOR, "adb", &adb_fops)) {
> printk(KERN_ERR "adb: unable to get major %d\n", ADB_MAJOR);
> - else
> - devfs_mk_cdev(MKDEV(ADB_MAJOR, 0),
> - S_IFCHR | S_IRUSR | S_IWUSR, "adb");
> + return;
> + }
> + adb_dev_class = class_simple_create(THIS_MODULE, "adb");
> + if (IS_ERR(adb_dev_class)) {
> + return;
> + }
> + class_simple_device_add(adb_dev_class, MKDEV(ADB_MAJOR, 0), NULL, "adb");
> }
--
Benjamin Herrenschmidt <benh@kernel.crashing.org>
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] simple class for adb
2004-05-01 22:36 ` Benjamin Herrenschmidt
@ 2004-05-02 4:07 ` Brad Boyer
2004-05-02 17:12 ` Cedric Pradalier
0 siblings, 1 reply; 6+ messages in thread
From: Brad Boyer @ 2004-05-02 4:07 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: Olaf Hering, linuxppc-dev list, Greg KH
On Sun, May 02, 2004 at 08:36:12AM +1000, Benjamin Herrenschmidt wrote:
> I'm not sure I want to keep /dev/adb forever.... This is at best a
> workaround so that udev creates it. Ultimately, we want a real adb
> bus in the device-model and a different mecanism to send special
> commands to the system controller. I think somebody from the m68k
> folks is already working on the ADB bus stuff though.
Slowly but surely, yes. Although perhaps just slowly. I've got part
of it written, but I haven't had any time the last month or so due
to my real job. I will probably have more time to finish up the
new ADB subsystem later this month.
I definitely agree on getting rid of most of the reasons for
/dev/adb, but I'm not sure what all people use through it. I know
the trackpad tool uses it, but I'm not sure of anything else.
Does the sleep stuff use /dev/adb or /dev/pmu?
Brad Boyer
flar@allandria.com
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] simple class for adb
2004-05-01 18:26 [PATCH] simple class for adb Olaf Hering
2004-05-01 22:36 ` Benjamin Herrenschmidt
@ 2004-05-02 8:14 ` Geert Uytterhoeven
2004-05-04 20:58 ` Greg KH
2 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2004-05-02 8:14 UTC (permalink / raw)
To: Olaf Hering; +Cc: Linux/PPC Development, Benjamin Herrenschmidt, Greg KH
On Sat, 1 May 2004, Olaf Hering wrote:
> This adds /sys/class/adb/, removes unused devfs lines and updates a
> comment to match reality.
And it still compiles on m68k.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] simple class for adb
2004-05-02 4:07 ` Brad Boyer
@ 2004-05-02 17:12 ` Cedric Pradalier
0 siblings, 0 replies; 6+ messages in thread
From: Cedric Pradalier @ 2004-05-02 17:12 UTC (permalink / raw)
To: linuxppc-dev
On Sat, 1 May 2004 21:07:25 -0700,
Brad Boyer gracefully wrote:
>
>On Sun, May 02, 2004 at 08:36:12AM +1000, Benjamin Herrenschmidt wrote:
>> I'm not sure I want to keep /dev/adb forever.... This is at best a
>> workaround so that udev creates it. Ultimately, we want a real adb
>> bus in the device-model and a different mecanism to send special
>> commands to the system controller. I think somebody from the m68k
>> folks is already working on the ADB bus stuff though.
>
>Slowly but surely, yes. Although perhaps just slowly. I've got part
>of it written, but I haven't had any time the last month or so due
>to my real job. I will probably have more time to finish up the
>new ADB subsystem later this month.
>
>I definitely agree on getting rid of most of the reasons for
>/dev/adb, but I'm not sure what all people use through it. I know
>the trackpad tool uses it, but I'm not sure of anything else.
>Does the sleep stuff use /dev/adb or /dev/pmu?
>
> Brad Boyer
> flar@allandria.com
>
>
>
>
Hi all,
I'm not sure it is related but I noticed on my ibook 2.2,
kernel <= 2.6.5, that sometimes some keyboards event are missed. With
xev, I keep seeing a key pushed (and repeating) whereas I released it.
To bring the system back to normal, I have to press and release the
repeating key, just to generate a release event, I guess.
Since it seems to be ppc-specific, I suspect adb. Does it make sense ?
Is it a known problem ?
--
Cedric
"[Of course] I'm French! Why do think I have this outrageous
accent, you silly king-a?!" Monty Python and the Holy Grail
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] simple class for adb
2004-05-01 18:26 [PATCH] simple class for adb Olaf Hering
2004-05-01 22:36 ` Benjamin Herrenschmidt
2004-05-02 8:14 ` Geert Uytterhoeven
@ 2004-05-04 20:58 ` Greg KH
2 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2004-05-04 20:58 UTC (permalink / raw)
To: Olaf Hering; +Cc: linuxppc-dev, Benjamin Herrenschmidt
On Sat, May 01, 2004 at 08:26:59PM +0200, Olaf Hering wrote:
>
> This adds /sys/class/adb/, removes unused devfs lines and updates a
> comment to match reality.
Applied, thanks.
greg k-h
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-05-04 20:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-05-01 18:26 [PATCH] simple class for adb Olaf Hering
2004-05-01 22:36 ` Benjamin Herrenschmidt
2004-05-02 4:07 ` Brad Boyer
2004-05-02 17:12 ` Cedric Pradalier
2004-05-02 8:14 ` Geert Uytterhoeven
2004-05-04 20:58 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).