* [PATCH] export clear_pages on ppc32
@ 2004-05-10 15:36 Olaf Hering
2004-05-10 18:42 ` Tom Rini
2004-05-10 22:42 ` Paul Mackerras
0 siblings, 2 replies; 6+ messages in thread
From: Olaf Hering @ 2004-05-10 15:36 UTC (permalink / raw)
To: akpm, Benjamin Herrenschmidt; +Cc: linuxppc-dev, Paul Mackeras
ext3 as module is not possible in 2.6.6, clear_pages, called from
clear_page, is not exported.
--- ./arch/ppc/kernel/ppc_ksyms.c~ 2004-05-10 04:33:19.000000000 +0200
+++ ./arch/ppc/kernel/ppc_ksyms.c 2004-05-10 17:32:17.663513410 +0200
@@ -73,6 +73,7 @@ int abs(int);
extern unsigned long mm_ptov (unsigned long paddr);
EXPORT_SYMBOL(clear_page);
+EXPORT_SYMBOL(clear_pages);
EXPORT_SYMBOL(clear_user_page);
EXPORT_SYMBOL(do_signal);
EXPORT_SYMBOL(do_syscall_trace);
--
USB is for mice, FireWire is for men!
sUse lINUX ag, nÜRNBERG
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] export clear_pages on ppc32
2004-05-10 15:36 [PATCH] export clear_pages on ppc32 Olaf Hering
@ 2004-05-10 18:42 ` Tom Rini
2004-05-10 19:17 ` Olaf Hering
2004-05-10 22:42 ` Paul Mackerras
1 sibling, 1 reply; 6+ messages in thread
From: Tom Rini @ 2004-05-10 18:42 UTC (permalink / raw)
To: Olaf Hering; +Cc: akpm, Benjamin Herrenschmidt, linuxppc-dev, Paul Mackeras
On Mon, May 10, 2004 at 05:36:24PM +0200, Olaf Hering wrote:
>
> ext3 as module is not possible in 2.6.6, clear_pages, called from
> clear_page, is not exported.
>
>
> --- ./arch/ppc/kernel/ppc_ksyms.c~ 2004-05-10 04:33:19.000000000 +0200
> +++ ./arch/ppc/kernel/ppc_ksyms.c 2004-05-10 17:32:17.663513410 +0200
> @@ -73,6 +73,7 @@ int abs(int);
> extern unsigned long mm_ptov (unsigned long paddr);
>
> EXPORT_SYMBOL(clear_page);
> +EXPORT_SYMBOL(clear_pages);
> EXPORT_SYMBOL(clear_user_page);
> EXPORT_SYMBOL(do_signal);
> EXPORT_SYMBOL(do_syscall_trace);
Where are clean_page and clear_pages defined? They should both be
exported there.
--
Tom Rini
http://gate.crashing.org/~trini/
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] export clear_pages on ppc32
2004-05-10 18:42 ` Tom Rini
@ 2004-05-10 19:17 ` Olaf Hering
2004-05-10 19:57 ` Tom Rini
0 siblings, 1 reply; 6+ messages in thread
From: Olaf Hering @ 2004-05-10 19:17 UTC (permalink / raw)
To: Tom Rini; +Cc: akpm, Benjamin Herrenschmidt, linuxppc-dev, Paul Mackeras
On Mon, May 10, Tom Rini wrote:
> On Mon, May 10, 2004 at 05:36:24PM +0200, Olaf Hering wrote:
>
> >
> > ext3 as module is not possible in 2.6.6, clear_pages, called from
> > clear_page, is not exported.
> >
> >
> > --- ./arch/ppc/kernel/ppc_ksyms.c~ 2004-05-10 04:33:19.000000000 +0200
> > +++ ./arch/ppc/kernel/ppc_ksyms.c 2004-05-10 17:32:17.663513410 +0200
> > @@ -73,6 +73,7 @@ int abs(int);
> > extern unsigned long mm_ptov (unsigned long paddr);
> >
> > EXPORT_SYMBOL(clear_page);
> > +EXPORT_SYMBOL(clear_pages);
> > EXPORT_SYMBOL(clear_user_page);
> > EXPORT_SYMBOL(do_signal);
> > EXPORT_SYMBOL(do_syscall_trace);
>
> Where are clean_page and clear_pages defined? They should both be
> exported there.
in misc.S, or some other .S file.
--
USB is for mice, FireWire is for men!
sUse lINUX ag, nÜRNBERG
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] export clear_pages on ppc32
2004-05-10 19:17 ` Olaf Hering
@ 2004-05-10 19:57 ` Tom Rini
0 siblings, 0 replies; 6+ messages in thread
From: Tom Rini @ 2004-05-10 19:57 UTC (permalink / raw)
To: Olaf Hering; +Cc: akpm, Benjamin Herrenschmidt, linuxppc-dev, Paul Mackeras
On Mon, May 10, 2004 at 09:17:38PM +0200, Olaf Hering wrote:
> On Mon, May 10, Tom Rini wrote:
> > On Mon, May 10, 2004 at 05:36:24PM +0200, Olaf Hering wrote:
> > > ext3 as module is not possible in 2.6.6, clear_pages, called from
> > > clear_page, is not exported.
> > >
> > >
> > > --- ./arch/ppc/kernel/ppc_ksyms.c~ 2004-05-10 04:33:19.000000000 +0200
> > > +++ ./arch/ppc/kernel/ppc_ksyms.c 2004-05-10 17:32:17.663513410 +0200
> > > @@ -73,6 +73,7 @@ int abs(int);
> > > extern unsigned long mm_ptov (unsigned long paddr);
> > >
> > > EXPORT_SYMBOL(clear_page);
> > > +EXPORT_SYMBOL(clear_pages);
> > > EXPORT_SYMBOL(clear_user_page);
> > > EXPORT_SYMBOL(do_signal);
> > > EXPORT_SYMBOL(do_syscall_trace);
> >
> > Where are clean_page and clear_pages defined? They should both be
> > exported there.
>
> in misc.S, or some other .S file.
OK, nevermind then.
--
Tom Rini
http://gate.crashing.org/~trini/
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] export clear_pages on ppc32
2004-05-10 15:36 [PATCH] export clear_pages on ppc32 Olaf Hering
2004-05-10 18:42 ` Tom Rini
@ 2004-05-10 22:42 ` Paul Mackerras
2004-05-11 13:25 ` Olaf Hering
1 sibling, 1 reply; 6+ messages in thread
From: Paul Mackerras @ 2004-05-10 22:42 UTC (permalink / raw)
To: Olaf Hering; +Cc: akpm, Benjamin Herrenschmidt, linuxppc-dev
Olaf Hering writes:
> ext3 as module is not possible in 2.6.6, clear_pages, called from
> clear_page, is not exported.
clear_page is an inline function now, we should remove its export.
Paul.
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] export clear_pages on ppc32
2004-05-10 22:42 ` Paul Mackerras
@ 2004-05-11 13:25 ` Olaf Hering
0 siblings, 0 replies; 6+ messages in thread
From: Olaf Hering @ 2004-05-11 13:25 UTC (permalink / raw)
To: Paul Mackerras; +Cc: akpm, Benjamin Herrenschmidt, linuxppc-dev
On Tue, May 11, Paul Mackerras wrote:
>
> Olaf Hering writes:
>
> > ext3 as module is not possible in 2.6.6, clear_pages, called from
> > clear_page, is not exported.
>
> clear_page is an inline function now, we should remove its export.
Good point:
diff -p -purN linux-2.6.6/arch/ppc/kernel/ppc_ksyms.c linux-2.6.6.ppc32/arch/ppc/kernel/ppc_ksyms.c
--- linux-2.6.6/arch/ppc/kernel/ppc_ksyms.c 2004-05-10 04:33:19.000000000 +0200
+++ linux-2.6.6.ppc32/arch/ppc/kernel/ppc_ksyms.c 2004-05-11 15:24:57.000000000 +0200
@@ -72,7 +72,7 @@ int abs(int);
extern unsigned long mm_ptov (unsigned long paddr);
-EXPORT_SYMBOL(clear_page);
+EXPORT_SYMBOL(clear_pages);
EXPORT_SYMBOL(clear_user_page);
EXPORT_SYMBOL(do_signal);
EXPORT_SYMBOL(do_syscall_trace);
--
USB is for mice, FireWire is for men!
sUse lINUX ag, nÜRNBERG
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-05-11 13:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-05-10 15:36 [PATCH] export clear_pages on ppc32 Olaf Hering
2004-05-10 18:42 ` Tom Rini
2004-05-10 19:17 ` Olaf Hering
2004-05-10 19:57 ` Tom Rini
2004-05-10 22:42 ` Paul Mackerras
2004-05-11 13:25 ` Olaf Hering
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).