[PATCH] MachineCheck exception broken for MPC 8xx CPU's

[PATCH] MachineCheck exception broken for MPC 8xx CPU's

[Joakim Tjernlund]

Hi Andrew

The Machine Check exception handler is broken on MPC 8xx CPU's
This patch should fix it.
Tom Rini asked me to send it to you.

Regards
  Joakim Tjernlund

Signed-off-by: Joakim Tjernlund

===== arch/ppc/kernel/head_8xx.S 1.20 vs edited =====
--- 1.20/arch/ppc/kernel/head_8xx.S	Tue Apr 20 22:39:28 2004
+++ edited/arch/ppc/kernel/head_8xx.S	Tue May 25 11:01:24 2004
@@ -207,6 +207,14 @@
 	EXCEPTION(0x100, Reset, UnknownException, EXC_XFER_STD)

 /* Machine check */
+	. = 0x200
+MachineCheck:
+	EXCEPTION_PROLOG
+	mfspr r4,DAR
+	stw r4,_DAR(r11)
+	mfspr r5,DSISR
+	stw r5,_DSISR(r11)
+	addi r3,r1,STACK_FRAME_OVERHEAD
 	EXC_XFER_STD(0x200, MachineCheckException)

 /* Data access exception.


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

Re: [PATCH] MachineCheck exception broken for MPC 8xx CPU's

[Paul Mackerras]

Joakim Tjernlund writes:

> The Machine Check exception handler is broken on MPC 8xx CPU's
> This patch should fix it.
> Tom Rini asked me to send it to you.

Hmmm, this doesn't look like it will apply.  The patch looks to be
against linuxppc-2.5, not Andrew's/Linus' tree.

In fact I don't think there is a great deal of point in applying this
patch until we update arch/ppc/kernel/head_8xx.S with all the other
changes we have in the linuxppc-2.5 tree.

Paul.

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

RE: [PATCH] MachineCheck exception broken for MPC 8xx CPU's

[Joakim Tjernlund]

> Joakim Tjernlund writes:
>
> > The Machine Check exception handler is broken on MPC 8xx CPU's
> > This patch should fix it.
> > Tom Rini asked me to send it to you.
>
> Hmmm, this doesn't look like it will apply.  The patch looks to be
> against linuxppc-2.5, not Andrew's/Linus' tree.

OOPS, I did not think. You are correct, this is against current linuxppc-2.5.

>
> In fact I don't think there is a great deal of point in applying this
> patch until we update arch/ppc/kernel/head_8xx.S with all the other
> changes we have in the linuxppc-2.5 tree.

Can you apply this to linuxppc-2.5 then?


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

Re: [PATCH] MachineCheck exception broken for MPC 8xx CPU's

[Tom Rini]

On Tue, May 25, 2004 at 08:17:19PM +1000, Paul Mackerras wrote:

> Joakim Tjernlund writes:
>
> > The Machine Check exception handler is broken on MPC 8xx CPU's
> > This patch should fix it.
> > Tom Rini asked me to send it to you.
>
> Hmmm, this doesn't look like it will apply.  The patch looks to be
> against linuxppc-2.5, not Andrew's/Linus' tree.
>
> In fact I don't think there is a great deal of point in applying this
> patch until we update arch/ppc/kernel/head_8xx.S with all the other
> changes we have in the linuxppc-2.5 tree.

Aside from one less thing to pull out and push ahead?  I was hoping to
avoid exactly that if possible. :)

--
Tom Rini
http://gate.crashing.org/~trini/

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

RE: [PATCH] MachineCheck exception broken for MPC 8xx CPU's

[Joakim Tjernlund]

> On Tue, May 25, 2004 at 08:17:19PM +1000, Paul Mackerras wrote:
>
> > Joakim Tjernlund writes:
> >
> > > The Machine Check exception handler is broken on MPC 8xx CPU's
> > > This patch should fix it.
> > > Tom Rini asked me to send it to you.
> >
> > Hmmm, this doesn't look like it will apply.  The patch looks to be
> > against linuxppc-2.5, not Andrew's/Linus' tree.
> >
> > In fact I don't think there is a great deal of point in applying this
> > patch until we update arch/ppc/kernel/head_8xx.S with all the other
> > changes we have in the linuxppc-2.5 tree.
>
> Aside from one less thing to pull out and push ahead?  I was hoping to
> avoid exactly that if possible. :)

Well, since the stock kernel is broken for 8xx I don't think that is going to work.
You need to push the 8xx changes in linuxppc-2.5 to akpm and then it will
be possible/meaningful to generate patches against the stock kernel.

 Jocke

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/