From: Tom Rini <trini@kernel.crashing.org>
To: Gabriel Paubert <paubert@iram.es>
Cc: Leigh Brown <leigh@solinno.co.uk>, linuxppc-dev@lists.linuxppc.org
Subject: Re: [RFC][PATCH 3/9] Support for old IBM PReP boxes
Date: Fri, 18 Jun 2004 08:35:06 -0700 [thread overview]
Message-ID: <20040618153506.GD811@smtp.west.cox.net> (raw)
In-Reply-To: <20040617223626.GB21217@iram.es>
On Fri, Jun 18, 2004 at 12:36:26AM +0200, Gabriel Paubert wrote:
> On Thu, Jun 17, 2004 at 09:16:16AM -0700, Tom Rini wrote:
> >
> > On Thu, Jun 10, 2004 at 05:55:56PM +0100, Leigh Brown wrote:
> >
> > >
> > > This patch adds a function residual_pcidev_irq() which finds out
> > > from the residual data which IRQ the given PCI device should use.
> > > The interesting part about this patch is the changes I made to
> > > prep_pcibios_fixup(). The old code was more than a little
> > > opaque so I tried to change it to make it a bit clearer. I'd
> > > definitely be pleased if someone could cast their eyes over
> > > that bit.
> >
> > Is this jsut a "Residual Data is Good" type change, or does it fix some
> > set of IBM machines? I ask since residual data on Motorola PRePs can be
> > incorrect, iirc.
>
> On my PreP machines (well PowerPlus since they are actually
> Raven/Falcon or Hawk based), the residual data for interrupt
> routing is correct, but some people insisted in writing code
> without having read the spec, and refused mine which correctly
> decoded this information :-(
Fixing things up to follow the spec, so long as there's not a good
reason to not follow the spec (e.g. more machines have out-of-spec data,
than do), maybe it'll get in now. :)
> BTW: I believe that we should really merge PPlus, MVME5100 and PreP,
> they are really minor variants (and on my MVME2[467]xx machine which
> boot as PreP, I reprogram the Raven/Hawk so that they look more like
> CHRP because I need a very large PCI address space, but 1GB of I/O
> space is stupid.
Actually, there's 2 directions that ideally, someday, we might go in:
- Make any subset of 'compatibile' machines configurable, e.g. a kernel
that works on pmac, pplus, and sbs k2 (but not also an ebony or
walnut)
- Finish ripping the pplus stuff out of prep*, since it's a bit better
supported in pplus.c (current 2.6) and if there's not a good reason
not to, merge mvme5100 stuff into another platform grouping (pplus if
it fits easily, for example).
--
Tom Rini
http://gate.crashing.org/~trini/
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2004-06-18 15:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-10 16:55 [RFC][PATCH 3/9] Support for old IBM PReP boxes Leigh Brown
2004-06-17 16:16 ` Tom Rini
2004-06-17 16:29 ` Leigh Brown
2004-06-17 18:57 ` Tom Rini
2004-06-17 22:36 ` Gabriel Paubert
2004-06-18 15:35 ` Tom Rini [this message]
2004-06-18 17:26 ` Leigh Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040618153506.GD811@smtp.west.cox.net \
--to=trini@kernel.crashing.org \
--cc=leigh@solinno.co.uk \
--cc=linuxppc-dev@lists.linuxppc.org \
--cc=paubert@iram.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).