From: Tom Rini <trini@kernel.crashing.org>
To: Olaf Hering <olh@suse.de>, Kumar Gala <kumar.gala@freescale.com>,
Matt Porter <mporter@kernel.crashing.org>
Cc: Andrew Morton <akpm@osdl.org>, linuxppc-dev@lists.linuxppc.org
Subject: Re: [PATCH] fix missing option in binutils version check
Date: Mon, 5 Jul 2004 11:32:19 -0700 [thread overview]
Message-ID: <20040705183219.GI2146@smtp.west.cox.net> (raw)
In-Reply-To: <20040704072350.GA7060@suse.de>
On Sun, Jul 04, 2004 at 09:23:50AM +0200, Olaf Hering wrote:
>
> On Sun, Jul 04, Olaf Hering wrote:
>
> >
> > On Tue, Jun 15, Tom Rini wrote:
> >
> > > And yes, passing -many does work on all older supported versions of
> > > binutils. So perhaps we should just add -Wa,-many to our cflags and be
> > > done with it now (and for future fixes of this sort).
> >
> > gcc 3.2 passes only -mppc, so all altive instructions will fail to
> > compile without either -many or -maltivec
> >
> > I have tested this patch with
> > gcc 3.2.3 + binutils-2.15.91.0.1
> > gcc 3.3.4 + binutils-2.15.91.0.1
> > gcc 3.4.1 + binutils-2.15.91.0.1
> > gcc 3.2.3 + binutils-2.15
> > gcc 3.3.4 + binutils-2.15
> > gcc 3.4.1 + binutils-2.15
>
> I meant to sent this version of the patch, really use -many also for the
> .S files.
[snip]
Kumar, Matt, can you give the following a shot on e500 and 4xx please?
This should fix Olaf's problem, and remove some workarounds for
previous binutils changes of this nature (to get 'foo' instruction, now
you must pass -mbar to the assembler):
Signed-off-by: Tom Rini <trini@kernel.crashing.org>
===== arch/ppc/Makefile 1.54 vs edited =====
--- 1.54/arch/ppc/Makefile 2004-06-26 14:10:12 -07:00
+++ edited/arch/ppc/Makefile 2004-07-05 11:27:18 -07:00
@@ -15,17 +15,15 @@
LDFLAGS_vmlinux := -Ttext $(KERNELLOAD) -Bstatic
CPPFLAGS += -Iarch/$(ARCH)
-AFLAGS += -Iarch/$(ARCH)
+AFLAGS += -Iarch/$(ARCH) -Wa,-many
cflags-y += -Iarch/$(ARCH) -msoft-float -pipe \
- -ffixed-r2 -Wno-uninitialized -mmultiple
+ -ffixed-r2 -Wno-uninitialized -mmultiple -Wa,-many
CPP = $(CC) -E $(CFLAGS)
ifndef CONFIG_E500
cflags-y += -mstring
endif
-cflags-$(CONFIG_4xx) += -Wa,-m405
-cflags-$(CONFIG_E500) += -Wa,-me500
cflags-$(CONFIG_PPC64BRIDGE) += -Wa,-mppc64bridge
CFLAGS += $(cflags-y)
===== arch/ppc/kernel/Makefile 1.47 vs edited =====
--- 1.47/arch/ppc/kernel/Makefile 2004-06-17 23:41:08 -07:00
+++ edited/arch/ppc/kernel/Makefile 2004-07-05 11:27:22 -07:00
@@ -5,12 +5,6 @@
ifdef CONFIG_PPC64BRIDGE
EXTRA_AFLAGS := -Wa,-mppc64bridge
endif
-ifdef CONFIG_4xx
-EXTRA_AFLAGS := -Wa,-m405
-endif
-ifdef CONFIG_E500
-EXTRA_AFLAGS := -Wa,-me500
-endif
extra-$(CONFIG_PPC_STD_MMU) := head.o
extra-$(CONFIG_40x) := head_4xx.o
If this does take care of everything, Paul, is this OK with you?
(and it might also remove the need for the -mppc64bridge bit, if
you'd like to test that. :))
--
Tom Rini
http://gate.crashing.org/~trini/
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2004-07-05 18:32 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-05 7:43 [PATCH] fix typo in binutils version check Olaf Hering
2004-06-05 10:40 ` Christian Kujau
2004-06-05 11:11 ` Olaf Hering
2004-06-05 13:11 ` Christian Kujau
2004-06-07 15:57 ` Tom Rini
2004-06-08 11:25 ` [PATCH] fix missing option " Olaf Hering
2004-06-10 0:16 ` Tom Rini
2004-06-14 9:15 ` Olaf Hering
2004-06-14 16:23 ` Tom Rini
2004-06-14 17:38 ` Olaf Hering
2004-06-14 18:07 ` Olaf Hering
2004-06-14 20:55 ` Tom Rini
2004-06-14 21:19 ` Olaf Hering
2004-06-15 16:12 ` Tom Rini
2004-06-15 17:25 ` Olaf Hering
2004-06-15 17:46 ` Tom Rini
2004-07-03 22:29 ` Olaf Hering
2004-07-04 1:30 ` Stef Simoens
2004-07-04 2:41 ` Tom Rini
2004-07-04 8:32 ` Geert Uytterhoeven
2004-07-04 16:33 ` Hollis Blanchard
2004-07-25 6:07 ` Alan Modra
2004-07-26 19:36 ` Tom Rini
2004-07-26 23:03 ` Alan Modra
2004-07-26 23:07 ` Tom Rini
2004-07-04 18:32 ` Tom Rini
2004-07-04 7:23 ` Olaf Hering
2004-07-05 18:32 ` Tom Rini [this message]
2004-07-09 1:34 ` Tom Rini
2004-07-09 1:43 ` Tom Rini
2004-07-12 9:06 ` Olaf Hering
2004-07-12 15:11 ` Tom Rini
2004-07-12 18:03 ` Tom Rini
2004-07-13 13:49 ` Olaf Hering
2004-07-13 14:01 ` Tom Rini
2004-07-13 14:02 ` Olaf Hering
2004-07-13 14:20 ` Tom Rini
2004-07-13 15:18 ` Olaf Hering
2004-07-13 15:26 ` Tom Rini
2004-07-13 15:29 ` Olaf Hering
2004-07-13 19:45 ` Tom Rini
2004-07-14 23:23 ` Tom Rini
2004-07-15 7:54 ` Geert Uytterhoeven
2004-07-15 12:50 ` Olaf Hering
2004-07-15 14:15 ` Tom Rini
2004-07-15 14:24 ` Olaf Hering
2004-07-15 14:23 ` Tom Rini
2004-07-05 18:18 ` Tom Rini
-- strict thread matches above, loose matches on Subject: below --
2004-06-10 16:19 Christian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040705183219.GI2146@smtp.west.cox.net \
--to=trini@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=kumar.gala@freescale.com \
--cc=linuxppc-dev@lists.linuxppc.org \
--cc=mporter@kernel.crashing.org \
--cc=olh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).