From: Matt Porter <mporter@kernel.crashing.org>
To: Ralph Siemsen <rsiemsen@rossvideo.com>
Cc: linuxppc-dev@lists.linuxppc.org
Subject: Re: ibm_ocp ethernet OPB clocks
Date: Thu, 8 Jul 2004 16:59:33 -0700 [thread overview]
Message-ID: <20040708165933.A11407@home.com> (raw)
In-Reply-To: <40EDC59E.9020403@rossvideo.com>; from rsiemsen@rossvideo.com on Thu, Jul 08, 2004 at 06:07:26PM -0400
On Thu, Jul 08, 2004 at 06:07:26PM -0400, Ralph Siemsen wrote:
>
> In pretty much all versions of the kernel (I checked 2.4.x, 2.6.7), one
> finds in drivers/net/ibm_ocp/ibm_ocp_emac.h:
>
> #define EMAC_M1_OPB_CLK_66 0x00000010 /* 66Mhz */
> #define EMAC_M1_OPB_CLK_83 0x00000008 /* 83hz */
>
> I believe these bitfield values are reversed... at least according to
> the 440GX usermanual, page 879. Bug/typo? Is the usermanual wrong? Or
> perhaps other 4xx series processors have different definitions?
>
> The definitions for 100MHz and >100MHz appear to be correct though.
I doublechecked that these didn't creep back in since I was sure I
fixed them. In 2.6.7 there is no drivers/net/ibm_ocp/ibm_ocp_emac.h
That driver has never been in kernel.org 2.6.7. I've just removed
it in linuxppc-2.5, since it's been deprecated by the new EMAC
driver. The corrected values are in there. Same goes for current
2.4. Try a current kernel.
> Is there a current maintainer for this driver?
That's me, now.
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2004-07-08 23:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-08 22:07 ibm_ocp ethernet OPB clocks Ralph Siemsen
2004-07-08 23:59 ` Matt Porter [this message]
2004-07-09 20:01 ` Ralph Siemsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040708165933.A11407@home.com \
--to=mporter@kernel.crashing.org \
--cc=linuxppc-dev@lists.linuxppc.org \
--cc=rsiemsen@rossvideo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).